diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2008-03-10 12:39:23 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2008-03-10 12:39:23 +0000 |
| commit | 23c356ccecaf10665777c05fac414466b7d5793d (patch) | |
| tree | 81e263f9f7dcc54883d5ff6e898acbe78de3ca65 /src | |
| parent | bfce56eea45b1369b7bb2150a150d1ac109f5073 (diff) | |
| download | postgresql-23c356ccecaf10665777c05fac414466b7d5793d.tar.gz | |
Document and enforce that the usable range of setseed() arguments is
-1 to 1, not 0 to 1. The actual behavior for values within this range
does not change. Kris Jurka
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/utils/adt/float.c | 8 | ||||
| -rw-r--r-- | src/backend/utils/misc/guc.c | 4 |
2 files changed, 8 insertions, 4 deletions
diff --git a/src/backend/utils/adt/float.c b/src/backend/utils/adt/float.c index e7d0cdd70d..2f1e262ea7 100644 --- a/src/backend/utils/adt/float.c +++ b/src/backend/utils/adt/float.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/utils/adt/float.c,v 1.153 2008/01/01 19:45:52 momjian Exp $ + * $PostgreSQL: pgsql/src/backend/utils/adt/float.c,v 1.154 2008/03/10 12:39:22 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -1684,8 +1684,12 @@ Datum setseed(PG_FUNCTION_ARGS) { float8 seed = PG_GETARG_FLOAT8(0); - int iseed = (int) (seed * MAX_RANDOM_VALUE); + int iseed; + if (seed < -1 || seed > 1) + elog(ERROR, "setseed parameter %f out of range [-1,1]", seed); + + iseed = (int) (seed * MAX_RANDOM_VALUE); srandom((unsigned int) iseed); PG_RETURN_VOID(); diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 2616c97953..49958cb4e7 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -10,7 +10,7 @@ * Written by Peter Eisentraut <peter_e@gmx.net>. * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.435 2008/03/10 03:22:29 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.436 2008/03/10 12:39:23 tgl Exp $ * *-------------------------------------------------------------------- */ @@ -1849,7 +1849,7 @@ static struct config_real ConfigureNamesReal[] = GUC_NO_SHOW_ALL | GUC_NO_RESET_ALL | GUC_NOT_IN_SAMPLE | GUC_DISALLOW_IN_FILE }, &phony_random_seed, - 0.5, 0.0, 1.0, assign_random_seed, show_random_seed + 0.0, -1.0, 1.0, assign_random_seed, show_random_seed }, { |