summaryrefslogtreecommitdiff
path: root/coverage/results.py
diff options
context:
space:
mode:
authorNed Batchelder <ned@nedbatchelder.com>2018-12-24 06:49:42 -0500
committerNed Batchelder <ned@nedbatchelder.com>2018-12-24 06:49:42 -0500
commitc4875b6ce2265e6797705508bae09a7a74a710e4 (patch)
tree73be898d3fea23716d4843256c6792b85151e6a8 /coverage/results.py
parent9f29efdf20c5dcfe49e85cc61c0839730be2462e (diff)
downloadpython-coveragepy-git-c4875b6ce2265e6797705508bae09a7a74a710e4.tar.gz
Tweaks to the fail_under limiting
Diffstat (limited to 'coverage/results.py')
-rw-r--r--coverage/results.py9
1 files changed, 5 insertions, 4 deletions
diff --git a/coverage/results.py b/coverage/results.py
index 9be16b15..ecd50ae9 100644
--- a/coverage/results.py
+++ b/coverage/results.py
@@ -7,7 +7,7 @@ import collections
from coverage.backward import iitems
from coverage.debug import SimpleReprMixin
-from coverage.misc import contract, format_lines
+from coverage.misc import contract, format_lines, CoverageException
class Analysis(object):
@@ -283,9 +283,10 @@ def should_fail_under(total, fail_under, precision):
Returns True if the total should fail.
"""
- # We can never achieve higher than 100% coverage
- if fail_under > 100.0:
- raise ValueError("`fail_under` is greater than 100. Please use 100 or lower.")
+ # We can never achieve higher than 100% coverage, or less than zero.
+ if not (0 <= fail_under <= 100.0):
+ msg = "fail_under={} is invalid. Must be between 0 and 100.".format(fail_under)
+ raise CoverageException(msg)
# Special case for fail_under=100, it must really be 100.
if fail_under == 100.0 and total != 100.0: