diff options
author | Pierre Sassoulas <pierre.sassoulas@gmail.com> | 2021-08-18 23:04:14 +0200 |
---|---|---|
committer | Pierre Sassoulas <pierre.sassoulas@gmail.com> | 2021-08-18 23:17:45 +0200 |
commit | 44fc1e1e23fd1d3b43cf80a10eb1c032a4312a2b (patch) | |
tree | 5c6c2ad5028be821b72fdbda71160fe22b93f0e3 /tests/unittest_objects.py | |
parent | 76036144e4b0049575d5c2f0c64d6365529ee9e7 (diff) | |
download | astroid-git-builtin-simplified.tar.gz |
Replace the constant BUILTINS by the string 'builtins'builtin-simplified
This make for clearer and also sligtly faster code (means time
seems to decrese by 0.68% with this change alone (astroid/pylint)
in the pylint tests benchmarks). Done because we were using an
import from astroid from astroid.bases for one of those, which is
kinda messy.
Diffstat (limited to 'tests/unittest_objects.py')
-rw-r--r-- | tests/unittest_objects.py | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/tests/unittest_objects.py b/tests/unittest_objects.py index f7c4d7cb..3c7ac52b 100644 --- a/tests/unittest_objects.py +++ b/tests/unittest_objects.py @@ -27,7 +27,7 @@ class ObjectsTest(unittest.TestCase): inferred = next(node.infer()) self.assertIsInstance(inferred, objects.FrozenSet) - self.assertEqual(inferred.pytype(), "%s.frozenset" % bases.BUILTINS) + self.assertEqual(inferred.pytype(), "builtins.frozenset") itered = inferred.itered() self.assertEqual(len(itered), 2) @@ -35,7 +35,7 @@ class ObjectsTest(unittest.TestCase): self.assertEqual([const.value for const in itered], [1, 2]) proxied = inferred._proxied - self.assertEqual(inferred.qname(), "%s.frozenset" % bases.BUILTINS) + self.assertEqual(inferred.qname(), "builtins.frozenset") self.assertIsInstance(proxied, nodes.ClassDef) @@ -58,15 +58,15 @@ class SuperTests(unittest.TestCase): ) in_static = next(ast_nodes[0].value.infer()) self.assertIsInstance(in_static, bases.Instance) - self.assertEqual(in_static.qname(), "%s.super" % bases.BUILTINS) + self.assertEqual(in_static.qname(), "builtins.super") module_level = next(ast_nodes[1].infer()) self.assertIsInstance(module_level, bases.Instance) - self.assertEqual(in_static.qname(), "%s.super" % bases.BUILTINS) + self.assertEqual(in_static.qname(), "builtins.super") no_arguments = next(ast_nodes[2].infer()) self.assertIsInstance(no_arguments, bases.Instance) - self.assertEqual(no_arguments.qname(), "%s.super" % bases.BUILTINS) + self.assertEqual(no_arguments.qname(), "builtins.super") def test_inferring_unbound_super_doesnt_work(self): node = builder.extract_node( @@ -78,7 +78,7 @@ class SuperTests(unittest.TestCase): ) unbounded = next(node.infer()) self.assertIsInstance(unbounded, bases.Instance) - self.assertEqual(unbounded.qname(), "%s.super" % bases.BUILTINS) + self.assertEqual(unbounded.qname(), "builtins.super") def test_use_default_inference_on_not_inferring_args(self): ast_nodes = builder.extract_node( @@ -91,11 +91,11 @@ class SuperTests(unittest.TestCase): ) first = next(ast_nodes[0].infer()) self.assertIsInstance(first, bases.Instance) - self.assertEqual(first.qname(), "%s.super" % bases.BUILTINS) + self.assertEqual(first.qname(), "builtins.super") second = next(ast_nodes[1].infer()) self.assertIsInstance(second, bases.Instance) - self.assertEqual(second.qname(), "%s.super" % bases.BUILTINS) + self.assertEqual(second.qname(), "builtins.super") def test_no_arguments_super(self): ast_nodes = builder.extract_node( @@ -239,7 +239,7 @@ class SuperTests(unittest.TestCase): ) inferred = next(node.infer()) proxied = inferred._proxied - self.assertEqual(proxied.qname(), "%s.super" % bases.BUILTINS) + self.assertEqual(proxied.qname(), "builtins.super") self.assertIsInstance(proxied, nodes.ClassDef) def test_super_bound_model(self): |