Deprecate html argument from Parsers

The defused XMLParse subclass no longer passes the html argument down
to the XMLParse class. The argument has been deprecated and ignored for
a long time. The DefusedXMLParser still takes a html argument. A
deprecation warning is issued when the argument is False and a TypeError
when it's True.

Fixes: https://github.com/tiran/defusedxml/issues/34
Co-authored-by: Erik Cederstrand <erik@cederstrand.dk>
Signed-off-by: Christian Heimes <christian@python.org>

1 files changed, 15 insertions, 1 deletions

diff --git a/tests.py b/tests.py
index 145172c..a769ac8 100644
--- a/tests.py
+++ b/tests.py
@@ -1,8 +1,10 @@
 from __future__ import print_function
+
+import io
 import os
 import sys
 import unittest
-import io
+import warnings
 
 from xml.sax.saxutils import XMLGenerator
 from xml.sax import SAXParseException
@@ -30,6 +32,12 @@ except ImportError:
     LXML3 = False
 
 
+warnings.filterwarnings(
+    'error',
+    category=DeprecationWarning,
+    module=r"defusedxml\..*"
+)
+
 HERE = os.path.dirname(os.path.abspath(__file__))
 
 # prevent web access
@@ -186,6 +194,12 @@ class TestDefusedElementTree(BaseTests):
     def iterparse(self, source, **kwargs):
         return list(self.module.iterparse(source, **kwargs))
 
+    def test_html_arg(self):
+        with self.assertRaises(DeprecationWarning):
+            ElementTree.XMLParse(html=0)
+        with self.assertRaises(TypeError):
+            ElementTree.XMLParse(html=1)
+
 
 class TestDefusedcElementTree(TestDefusedElementTree):
     module = cElementTree