diff options
| author | Nejc Habjan <nejc.habjan@siemens.com> | 2022-06-20 17:16:08 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-20 17:16:08 +0200 |
| commit | 41ceaca1cdee6251beb453f22b7def3c95b279a5 (patch) | |
| tree | 22bec5b9dffafa602069245bdaccec63bbf5b631 | |
| parent | e48ad91cbd7ee40f3d21e11700e22a754e14e31e (diff) | |
| parent | 15a242c3303759b77b380c5b3ff9d1e0bf2d800c (diff) | |
| download | gitlab-41ceaca1cdee6251beb453f22b7def3c95b279a5.tar.gz | |
Merge pull request #2066 from python-gitlab/jlvillal/approval_rule_id
fix(cli): project-merge-request-approval-rule
| -rw-r--r-- | gitlab/v4/objects/merge_request_approvals.py | 3 | ||||
| -rw-r--r-- | tests/unit/objects/test_project_merge_request_approvals.py | 1 |
2 files changed, 2 insertions, 2 deletions
diff --git a/gitlab/v4/objects/merge_request_approvals.py b/gitlab/v4/objects/merge_request_approvals.py index a22bd2b..eb243c7 100644 --- a/gitlab/v4/objects/merge_request_approvals.py +++ b/gitlab/v4/objects/merge_request_approvals.py @@ -165,8 +165,7 @@ class ProjectMergeRequestApprovalManager(GetWithoutIdMixin, UpdateMixin, RESTMan class ProjectMergeRequestApprovalRule(SaveMixin, ObjectDeleteMixin, RESTObject): - _id_attr = "approval_rule_id" - _repr_attr = "approval_rule" + _repr_attr = "name" id: int approval_rule_id: int merge_request_iid: int diff --git a/tests/unit/objects/test_project_merge_request_approvals.py b/tests/unit/objects/test_project_merge_request_approvals.py index 5a87552..27bbc84 100644 --- a/tests/unit/objects/test_project_merge_request_approvals.py +++ b/tests/unit/objects/test_project_merge_request_approvals.py @@ -168,6 +168,7 @@ def test_list_merge_request_approval_rules(project, resp_mr_approval_rules): assert len(approval_rules) == 1 assert approval_rules[0].name == approval_rule_name assert approval_rules[0].id == approval_rule_id + repr(approval_rules) # ensure that `repr()` doesn't raise an exception def test_delete_merge_request_approval_rule(project, resp_delete_mr_approval_rule): |