diff options
| author | John L. Villalovos <john@sodarock.com> | 2021-03-14 16:21:45 -0700 |
|---|---|---|
| committer | John L. Villalovos <john@sodarock.com> | 2021-03-15 08:34:43 -0700 |
| commit | 2afd18aa28742a3267742859a88be6912a803874 (patch) | |
| tree | f533941c0a3aeef6346a5345a8e624716f196e1d /gitlab/tests/objects | |
| parent | 8ace76a8a5596171c782570fdde7a82119aeb9ff (diff) | |
| download | gitlab-2afd18aa28742a3267742859a88be6912a803874.tar.gz | |
chore: remove usage of getattr()
Remove usage of getattr(self, "_update_uses_post", False)
Instead add it to class and set default value to False.
Add a tests that shows it is set to True for the
ProjectMergeRequestApprovalManager and ProjectApprovalManager classes.
Diffstat (limited to 'gitlab/tests/objects')
| -rw-r--r-- | gitlab/tests/objects/test_project_merge_request_approvals.py | 26 |
1 files changed, 25 insertions, 1 deletions
diff --git a/gitlab/tests/objects/test_project_merge_request_approvals.py b/gitlab/tests/objects/test_project_merge_request_approvals.py index 5e9244f..a8e31e6 100644 --- a/gitlab/tests/objects/test_project_merge_request_approvals.py +++ b/gitlab/tests/objects/test_project_merge_request_approvals.py @@ -2,9 +2,12 @@ Gitlab API: https://docs.gitlab.com/ee/api/merge_request_approvals.html """ +import copy + import pytest import responses -import copy + +import gitlab approval_rule_id = 1 @@ -230,6 +233,17 @@ def resp_snippet(): yield rsps +def test_project_approval_manager_update_uses_post(project, resp_snippet): + """Ensure the + gitlab.v4.objects.merge_request_approvals.ProjectApprovalManager object has + _update_uses_post set to True""" + approvals = project.approvals + assert isinstance( + approvals, gitlab.v4.objects.merge_request_approvals.ProjectApprovalManager + ) + assert approvals._update_uses_post == True + + def test_list_merge_request_approval_rules(project, resp_snippet): approval_rules = project.mergerequests.get(1).approval_rules.list() assert len(approval_rules) == 1 @@ -239,6 +253,11 @@ def test_list_merge_request_approval_rules(project, resp_snippet): def test_update_merge_request_approvals_set_approvers(project, resp_snippet): approvals = project.mergerequests.get(1).approvals + assert isinstance( + approvals, + gitlab.v4.objects.merge_request_approvals.ProjectMergeRequestApprovalManager, + ) + assert approvals._update_uses_post == True response = approvals.set_approvers( updated_approval_rule_approvals_required, approver_ids=updated_approval_rule_user_ids, @@ -254,6 +273,11 @@ def test_update_merge_request_approvals_set_approvers(project, resp_snippet): def test_create_merge_request_approvals_set_approvers(project, resp_snippet): approvals = project.mergerequests.get(1).approvals + assert isinstance( + approvals, + gitlab.v4.objects.merge_request_approvals.ProjectMergeRequestApprovalManager, + ) + assert approvals._update_uses_post == True response = approvals.set_approvers( new_approval_rule_approvals_required, approver_ids=new_approval_rule_user_ids, |