diff options
| author | John L. Villalovos <john@sodarock.com> | 2021-03-07 11:31:23 -0800 |
|---|---|---|
| committer | Nejc Habjan <hab.nejc@gmail.com> | 2021-04-17 17:09:41 +0200 |
| commit | aee1f496c1f414c1e30909767d53ae624fe875e7 (patch) | |
| tree | 04a7fe9d8f77cffeae733bb8dd3447911995f3a1 /gitlab/v4/objects/issues.py | |
| parent | 8603248f73d8c751023fbfd2a394c5b7d939af7f (diff) | |
| download | gitlab-aee1f496c1f414c1e30909767d53ae624fe875e7.tar.gz | |
chore: have _create_attrs & _update_attrs be a namedtuple
Convert _create_attrs and _update_attrs to use a NamedTuple
(RequiredOptional) to help with code readability. Update all code to
use the NamedTuple.
Diffstat (limited to 'gitlab/v4/objects/issues.py')
| -rw-r--r-- | gitlab/v4/objects/issues.py | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/gitlab/v4/objects/issues.py b/gitlab/v4/objects/issues.py index dfd43f5..4da7f91 100644 --- a/gitlab/v4/objects/issues.py +++ b/gitlab/v4/objects/issues.py @@ -1,6 +1,6 @@ from gitlab import cli, types from gitlab import exceptions as exc -from gitlab.base import RESTManager, RESTObject +from gitlab.base import RequiredOptional, RESTManager, RESTObject from gitlab.mixins import ( CRUDMixin, CreateMixin, @@ -188,9 +188,9 @@ class ProjectIssueManager(CRUDMixin, RESTManager): "updated_after", "updated_before", ) - _create_attrs = ( - ("title",), - ( + _create_attrs = RequiredOptional( + required=("title",), + optional=( "description", "confidential", "assignee_ids", @@ -203,9 +203,8 @@ class ProjectIssueManager(CRUDMixin, RESTManager): "discussion_to_resolve", ), ) - _update_attrs = ( - tuple(), - ( + _update_attrs = RequiredOptional( + optional=( "title", "description", "confidential", @@ -230,7 +229,7 @@ class ProjectIssueLinkManager(ListMixin, CreateMixin, DeleteMixin, RESTManager): _path = "/projects/%(project_id)s/issues/%(issue_iid)s/links" _obj_cls = ProjectIssueLink _from_parent_attrs = {"project_id": "project_id", "issue_iid": "iid"} - _create_attrs = (("target_project_id", "target_issue_iid"), tuple()) + _create_attrs = RequiredOptional(required=("target_project_id", "target_issue_iid")) @exc.on_http_error(exc.GitlabCreateError) def create(self, data, **kwargs): |