summaryrefslogtreecommitdiff
path: root/git/config.py
diff options
context:
space:
mode:
authorYobmod <yobmod@gmail.com>2021-07-19 19:10:45 +0100
committerYobmod <yobmod@gmail.com>2021-07-19 19:10:45 +0100
commit9e5e969479ec6018e1ba06b95bcdefca5b0082a4 (patch)
tree574e03c6c4acd1067e3b285974651ec9e9529a49 /git/config.py
parent9a587e14d509cc77bf47b9591d1def3e5a1df570 (diff)
downloadgitpython-9e5e969479ec6018e1ba06b95bcdefca5b0082a4.tar.gz
Change remaining type comments to py3.6+ types
Diffstat (limited to 'git/config.py')
-rw-r--r--git/config.py18
1 files changed, 10 insertions, 8 deletions
diff --git a/git/config.py b/git/config.py
index e0a18ec8..345cb40e 100644
--- a/git/config.py
+++ b/git/config.py
@@ -208,7 +208,7 @@ class _OMD(OrderedDict):
def getall(self, key: str) -> Any:
return super(_OMD, self).__getitem__(key)
- def items(self) -> List[Tuple[str, Any]]: # type: ignore ## mypy doesn't like overwriting supertype signitures
+ def items(self) -> List[Tuple[str, Any]]: # type: ignore[override]
"""List of (key, last value for key)."""
return [(k, self[k]) for k in self]
@@ -322,7 +322,7 @@ class GitConfigParser(with_metaclass(MetaParserBuilder, cp.RawConfigParser)): #
self._is_initialized = False
self._merge_includes = merge_includes
self._repo = repo
- self._lock = None # type: Union['LockFile', None]
+ self._lock: Union['LockFile', None] = None
self._acquire_lock()
def _acquire_lock(self) -> None:
@@ -545,13 +545,15 @@ class GitConfigParser(with_metaclass(MetaParserBuilder, cp.RawConfigParser)): #
return None
self._is_initialized = True
- files_to_read = [""] # type: List[Union[PathLike, IO]] ## just for types until 3.5 dropped
- if isinstance(self._file_or_files, (str)): # replace with PathLike once 3.5 dropped
- files_to_read = [self._file_or_files] # for str, as str is a type of Sequence
+ files_to_read: List[Union[PathLike, IO]] = [""]
+ if isinstance(self._file_or_files, (str, os.PathLike)):
+ # for str or Path, as str is a type of Sequence
+ files_to_read = [self._file_or_files]
elif not isinstance(self._file_or_files, (tuple, list, Sequence)):
- files_to_read = [self._file_or_files] # for IO or Path
- else:
- files_to_read = list(self._file_or_files) # for lists or tuples
+ # could merge with above isinstance once runtime type known
+ files_to_read = [self._file_or_files]
+ else: # for lists or tuples
+ files_to_read = list(self._file_or_files)
# end assure we have a copy of the paths to handle
seen = set(files_to_read)