diff options
author | Kostis Anagnostopoulos <ankostis@gmail.com> | 2016-09-28 01:05:38 +0200 |
---|---|---|
committer | Kostis Anagnostopoulos <ankostis@gmail.com> | 2016-09-28 03:35:38 +0200 |
commit | a5db3d3c49ebe559cb80983d7bb855d4adf1b887 (patch) | |
tree | 8cc2b645e97c5420978ee8fcadc528e878fa99d9 /git/test/lib/helper.py | |
parent | 467416356a96148bcb01feb771f6ea20e5215727 (diff) | |
download | gitpython-a5db3d3c49ebe559cb80983d7bb855d4adf1b887.tar.gz |
io, dif: #519: FIX DIFF freeze when reading from GIL
+ CAUSE: In Windows, Diffs freeze while reading Popen streams,
probably buffers smaller; good-thin(TM) in this case because reading a
Popen-proc from the launching-thread freezes GIL. The alternative to
use `proc.communicate()` also relies on big buffers.
+ SOLUTION: Use `cmd.handle_process_output()` to consume Diff-proc
streams.
+ Retroffited `handle_process_output()` code to support also
byte-streams, both Threading(Windows) and Select/Poll (Posix) paths
updated.
- TODO: Unfortunately, `Diff._index_from_patch_format()` still slurps
input; need to re-phrase header-regexes linewise to resolve it.
Diffstat (limited to 'git/test/lib/helper.py')
0 files changed, 0 insertions, 0 deletions