summaryrefslogtreecommitdiff
path: root/git/test/test_repo.py
diff options
context:
space:
mode:
authorKostis Anagnostopoulos <ankostis@gmail.com>2016-10-03 12:25:09 +0200
committerKostis Anagnostopoulos <ankostis@gmail.com>2016-10-04 01:26:51 +0200
commitbe44602b633cfb49a472e192f235ba6de0055d38 (patch)
treef3bf2cf426e682aba1487174e7e38bd652b09a27 /git/test/test_repo.py
parent86aa8738e0df54971e34f2e929484e0476c7f38a (diff)
downloadgitpython-be44602b633cfb49a472e192f235ba6de0055d38.tar.gz
hidden win-errs: Let leaking TCs run till end, then hide
+ Detect code breaking the body of TCs eventually hidden win-errors by raising SkipTest ALAP. + submodule.base.py: import classes from `git.objects` instead of `utils`. + had to ++ ulimit 100->110 for the extra code tested (more leaks :-) + Centralize is_win detection.
Diffstat (limited to 'git/test/test_repo.py')
-rw-r--r--git/test/test_repo.py8
1 files changed, 4 insertions, 4 deletions
diff --git a/git/test/test_repo.py b/git/test/test_repo.py
index 35720fc2..28cc45d9 100644
--- a/git/test/test_repo.py
+++ b/git/test/test_repo.py
@@ -797,7 +797,7 @@ class TestRepo(TestBase):
git_file_repo = Repo(rwrepo.working_tree_dir)
self.assertEqual(os.path.abspath(git_file_repo.git_dir), real_path_abs)
- @skipIf(HIDE_WINDOWS_KNOWN_ERRORS and is_win and PY3,
+ @skipIf(HIDE_WINDOWS_KNOWN_ERRORS and PY3,
"FIXME: smmp fails with: TypeError: Can't convert 'bytes' object to str implicitly")
def test_file_handle_leaks(self):
def last_commit(repo, rev, path):
@@ -897,9 +897,9 @@ class TestRepo(TestBase):
for i, j in itertools.permutations([c1, 'ffffff', ''], r=2):
self.assertRaises(GitCommandError, repo.is_ancestor, i, j)
- @skipIf(HIDE_WINDOWS_KNOWN_ERRORS and is_win,
- "FIXME: helper.wrapper fails with: PermissionError: [WinError 5] Access is denied: "
- "'C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\test_work_tree_unsupportedryfa60di\\master_repo\\.git\\objects\\pack\\pack-bc9e0787aef9f69e1591ef38ea0a6f566ec66fe3.idx") # noqa E501
+ # @skipIf(HIDE_WINDOWS_KNOWN_ERRORS,
+ # "FIXME: helper.wrapper fails with: PermissionError: [WinError 5] Access is denied: "
+ # "'C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\test_work_tree_unsupportedryfa60di\\master_repo\\.git\\objects\\pack\\pack-bc9e0787aef9f69e1591ef38ea0a6f566ec66fe3.idx") # noqa E501
@with_rw_directory
def test_work_tree_unsupported(self, rw_dir):
git = Git(rw_dir)