workerthread: adjusted to use a blocking queue, it will receive termination events only with its queue, with boosts performance into brigt green levels

1 files changed, 17 insertions, 7 deletions

diff --git a/lib/git/async/thread.py b/lib/git/async/thread.py
index 5faad4f8..556b7e92 100644
--- a/lib/git/async/thread.py
+++ b/lib/git/async/thread.py
@@ -80,6 +80,10 @@ class TerminatableThread(threading.Thread):
 		self._terminated()
 	#} END interface
 	
+	
+class StopProcessing(Exception):
+	"""If thrown in a function processed by a WorkerThread, it will terminate"""
+	
 
 class WorkerThread(TerminatableThread):
 	""" This base allows to call functions on class instances natively.
@@ -122,6 +126,11 @@ class WorkerThread(TerminatableThread):
 		self.inq = inq or Queue.Queue()
 		self._current_routine = None				# routine we execute right now
 	
+	@classmethod
+	def stop(cls, *args):
+		"""If send via the inq of the thread, it will stop once it processed the function"""
+		raise StopProcessing
+	
 	def run(self):
 		"""Process input tasks until we receive the quit signal"""
 		gettask = self.inq.get
@@ -131,12 +140,8 @@ class WorkerThread(TerminatableThread):
 				break
 			# END check for stop request
 			
-			# don't wait too long, instead check for the termination request more often
-			try:
-				tasktuple = gettask(True, 0.25)
-			except Queue.Empty:
-				continue
-			# END get task with timeout
+			# we wait and block - to terminate, send the 'stop' method
+			tasktuple = gettask()
 			
 			# needing exactly one function, and one arg
 			assert len(tasktuple) == 2, "Need tuple of function, arg - it could be more flexible, but its reduced to what we need"
@@ -158,6 +163,8 @@ class WorkerThread(TerminatableThread):
 					print "%s: task %s was not understood - terminating" % (self.getName(), str(tasktuple))
 					break
 				# END make routine call
+			except StopProcessing:
+				break
 			except Exception,e:
 				print "%s: Task %s raised unhandled exception: %s - this really shouldn't happen !" % (self.getName(), str(tasktuple), str(e))
 				break	# abort ... 
@@ -168,5 +175,8 @@ class WorkerThread(TerminatableThread):
 		""":return: routine we are currently executing, or None if we have no task"""
 		return self._current_routine
 	
-	
+	def stop_and_join(self):
+		"""Send stop message to ourselves"""
+		self.inq.put((self.stop, None))
+		super(WorkerThread, self).stop_and_join()
 #} END classes