remove ambiguity between paths and treeishs

When calling commands that accept treeish and path arguments and there is a path with the same name as a treeish git cowardly refuses to pick one and asks for the command to use the unambiguous syntax where '--' seperates the treeish from the paths.  Add '--' to the git commands to indicate that the argument is a treeish and not a path.
(cherry picked from commit a9a57fa93a2b121ab9b17fcd6062b9a9c9740883)

1 files changed, 5 insertions, 6 deletions

diff --git a/lib/git/repo.py b/lib/git/repo.py
index a3874259..09215b1e 100644
--- a/lib/git/repo.py
+++ b/lib/git/repo.py
@@ -192,8 +192,8 @@ class Repo(object):
         Returns 
             ``git.Commit[]``
         """
-        repo_refs = self.git.rev_list(ref).strip().splitlines()
-        other_repo_refs = other_repo.git.rev_list(other_ref).strip().splitlines()
+        repo_refs = self.git.rev_list(ref, '--').strip().splitlines()
+        other_repo_refs = other_repo.git.rev_list(other_ref, '--').strip().splitlines()
 
         diff_refs = list(set(other_repo_refs) - set(repo_refs))
         return map(lambda ref: Commit.find_all(other_repo, ref, max_count=1)[0], diff_refs)
@@ -236,10 +236,9 @@ class Repo(object):
         """
         options = {'pretty': 'raw'}
         options.update(kwargs)
+        arg = [commit, '--']
         if path:
-            arg = [commit, '--', path]
-        else:
-            arg = [commit]
+            arg.append(path)
         commits = self.git.log(*arg, **options)
         return Commit.list_from_string(self, commits)
 
@@ -450,7 +449,7 @@ class Repo(object):
             # always consired to be clean.
             return False
 
-        return len(self.git.diff('HEAD').strip()) > 0
+        return len(self.git.diff('HEAD', '--').strip()) > 0
 
     @property
     def active_branch(self):