summaryrefslogtreecommitdiff
path: root/lib/git/async/pool.py
Commit message (Collapse)AuthorAgeFilesLines
* Removed async from treeSebastian Thiel2010-06-121-488/+0
|
* Cleaned up channel design, Reader and Writer bases don't require a channel ↵Sebastian Thiel2010-06-121-7/+8
| | | | | | anymore, but are abstract. Added IteratorReader, implementing the reader interface from an iterator. The implementation moved from the TaskIterator to the channel
* test_task: fixed import error, made all modules from x import * safeSebastian Thiel2010-06-111-0/+2
|
* Removed commented-out debug code and additional debug printings. Verified it ↵Sebastian Thiel2010-06-111-6/+0
| | | | works on py2.4, 2.5 and 2.6
* IMPORTANT: sometimes, when notifying waiters by releasing their lock, the ↵Sebastian Thiel2010-06-111-1/+0
| | | | lock is not actually released or they are not actually notifyied, staying in a beautysleep. This glitch is probably caused by some detail not treated correctly in the thread python module, which is something we cannot fix. It works most of the time as expected though - maybe some cleanup is not done correctly which causes this
* Added dependency-task tests, and fixed plenty of ref-count related bugs, as ↵Sebastian Thiel2010-06-101-1/+1
| | | | well as concurrency issues. Now it works okay, but the thread-shutdown is still an issue, as it causes incorrect behaviour making the tests fail. Its good, as it hints at additional issues that need to be solved. There is just a little more left on the feature side, but its nearly there
* Now tracking the amount of concurrent writers to assure the channel is ↵Sebastian Thiel2010-06-101-10/+14
| | | | closed only when there is no one else writing to it. This assures that all tasks can continue working, and put their results accordingly. Shutdown is still not working correctly, but that should be solvable as well. Its still not perfect though ...
* channel: Changed design to be more logical - a channel now has any amount of ↵Sebastian Thiel2010-06-101-39/+37
| | | | | | readers and writers, a ready is not connected to its writer anymore. This changes the refcounting of course, which is why the auto-cleanup for the pool is currently broken. The benefit of this are faster writes to the channel, reading didn't improve, refcounts should be clearer now
* InputChannelTask now has interface for properly handling the reading from ↵Sebastian Thiel2010-06-101-4/+39
| | | | the same and different pools
* messy first version of a properly working depth-first graph method, which ↵Sebastian Thiel2010-06-101-3/+3
| | | | allows the pool to work as expected. Many more tests need to be added, and there still is a problem with shutdown as sometimes it won't kill all threads, mainly because the process came up with worker threads started, which cannot be
* test: prepared task dependency test, which already helped to find bug in the ↵Sebastian Thiel2010-06-091-16/+39
| | | | reference counting mechanism, causing references to the pool to be kepts via cycles
* task: redesigned write channel access to allow the task creator to set own ↵Sebastian Thiel2010-06-091-5/+8
| | | | write channels, possibly some with callbacks installed etc.. Pool.add_task will respect the users choice now, but provide defaults which are optimized for performance
* Channel: Callbacks reviewed - they are now part of Subclasses of the default ↵Sebastian Thiel2010-06-091-45/+6
| | | | channel implementation, one of which is used as base by the Pool Read channel, releasing it of the duty to call these itself. The write channel with callback subclass allows the transformation of the item to be written
* task: removed scheduled task support, which at some point was introduced to ↵Sebastian Thiel2010-06-091-32/+11
| | | | improve performance, but which now hinders performance, besides being unnecessary ;)
* Channel: removed pseudoconstructor, which clearly improves the design and ↵Sebastian Thiel2010-06-091-13/+23
| | | | | | makes it easier to constomize pool: in serial mode, created channels will be serial-only, which brings 15% of performance
* HSCondition: Fixed terrible bug which it inherited from its default python ↵Sebastian Thiel2010-06-091-2/+5
| | | | | | Condition implementation, related to the notify method not being treadsafe. Although I was aware of it, I missed the first check which tests for the size - the result could be incorrect if the whole method wasn't locked. Testing runs stable now, allowing to move on \!
* thread: fixed initialization problem if an empty iterable was handed inSebastian Thiel2010-06-091-3/+2
| | | | | queue: Queue now derives from deque directly, which safes one dict lookup as the queue does not need to be accessed through self anymore pool test improved to better verify threads are started correctly
* queue: fixed critical bug in the notify method, as it was not at all ↵Sebastian Thiel2010-06-091-16/+14
| | | | | | thread-safe, causing locks to be released multiple times. Now it runs very fast, and very stable apparently. Now its about putting previous features back in, and studying their results, before more complex task graphs can be examined
* workerthread: adjusted to use a blocking queue, it will receive termination ↵Sebastian Thiel2010-06-081-23/+33
| | | | events only with its queue, with boosts performance into brigt green levels
* Revised task deletion works well, adjusted test to be creating new tasks all ↵Sebastian Thiel2010-06-081-5/+20
| | | | the time instead of reusing its own one, it was somewhat hard to manage its state over time and could cause bugs. It works okay, but it occasionally hangs, it appears to be an empty queue, have to gradually put certain things back in, although in the current mode of operation, it should never have empty queues from the pool to the user
* task: now deletes itself once its done - for the test this doesn't change a ↵Sebastian Thiel2010-06-081-42/+15
| | | | thing as the task deletes itself too late - its time for a paradigm change, the task should be deleted with its RPoolChannel or explicitly by the user. The test needs to adapt, and shouldn't assume anything unless the RPoolChannel is gone
* Its getting better already - intermediate commit before further chaning the ↵Sebastian Thiel2010-06-081-3/+4
| | | | task class
* Task scheduled items lock now uses a dummy lock in serial mode, improving ↵Sebastian Thiel2010-06-071-0/+6
| | | | | | its performance considerably. Channels now use the AsyncQueue, boosting their throughput to about 5k items / s - this is something one can work with, considering the runtime of each item should be large enough to keep the threads busy. This could be a basis, further testing needed
* introduced a new counter keeping track of the scheduled tasks - this prevent ↵Sebastian Thiel2010-06-071-2/+13
| | | | unnecessary tasks to be scheduled as we keep track of how many items will be produced for the task at hand. This introduces additional locking, but performns well in multithreaded mode. Performance of the master queue is still a huge issue, its currently the limiting factor, as bypassing the master queue in serial moode gives 15x performance, wich is what I would need
* improved testing to test the actual async handling of the pool. there are ↵Sebastian Thiel2010-06-071-3/+15
| | | | still inconsistencies that need to be fixed, but it already improved, especially the 4-thread performance which now is as fast as the dual-threaded performance
* task: Fixed incorrect handling of channel closure. Performance is alright ↵Sebastian Thiel2010-06-071-22/+18
| | | | for up to 2 threads, but 4 are killing the queue
* Moved pool utilities into util module, fixed critical issue that caused ↵Sebastian Thiel2010-06-071-118/+36
| | | | havok - lets call this a safe-state
* added high-speed locking facilities, allowing our Queue to be faster, at ↵Sebastian Thiel2010-06-071-55/+186
| | | | least in tests, and with multiple threads. There is still an sync bug in regard to closed channels to be fixed, as the Task.set_done handling is incorrecft
* Added task order cache, and a lock to prevent us walking the graph while ↵Sebastian Thiel2010-06-071-5/+21
| | | | | | changing tasks Now processing more items to test performance, in dual-threaded mode as well, and its rather bad, have to figure out the reason for this, probably gil, but queues could help
* changed scheduling and chunksize calculation in respect to the ↵Sebastian Thiel2010-06-071-76/+137
| | | | task.min_count, to fix theoretical option for a deadlock in serial mode, and unnecessary blocking in async mode
* pool.consumed_tasks: is now a queue to be thread safe, in preparation for ↵Sebastian Thiel2010-06-071-11/+18
| | | | | | multiple connected pools Reduced waiting time in tests to make them complete faster
* pool: First version which works as expected in async mode. Its just using a ↵Sebastian Thiel2010-06-071-17/+27
| | | | single task for now, but next up are dependent tasks
* Plenty of fixes in the chunking routine, made possible by a serialized ↵Sebastian Thiel2010-06-061-15/+51
| | | | chunking test. Next up, actual async processing
* First step of testing the pool - tasks have been separated into a new module ↵Sebastian Thiel2010-06-061-104/+60
| | | | including own tests, their design improved to prepare them for some specifics that would be needed for multiprocessing support
* thread: adjusted worker thread not to provide an output queue anymore - this ↵Sebastian Thiel2010-06-061-5/+48
| | | | | | | is handled by the task system graph: implemented it including test according to the pools requirements pool: implemented set_pool_size
* Improved pool design and started rough implementation, top down to learn ↵Sebastian Thiel2010-06-061-56/+217
| | | | while going. Tests will be written soon for verification, its still quite theoretical
* Renamed mp to async, as this is a much better name for what is actually ↵Sebastian Thiel2010-06-051-0/+116
going on. The default implementation uses threads, which ends up being nothing more than async, as they are all locked down by internal and the global interpreter lock