summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDana Powers <dana.powers@rd.io>2018-03-09 10:44:22 -0500
committerDana Powers <dana.powers@rd.io>2018-03-09 10:44:22 -0500
commit12ea1515eee9b1fd880169ac2acb2aa678bbe568 (patch)
treead48c5c0398b6770da381216e2cc2af41e8aef31
parentd90cf22bcf5c49b6d75cac4282d7cc2ae973651c (diff)
downloadkafka-python-log_check_version.tar.gz
Re-enable logging during broker version checklog_check_version
-rw-r--r--kafka/conn.py13
1 files changed, 1 insertions, 12 deletions
diff --git a/kafka/conn.py b/kafka/conn.py
index bfaed6a..031ca87 100644
--- a/kafka/conn.py
+++ b/kafka/conn.py
@@ -859,6 +859,7 @@ class BrokerConnection(object):
Returns: version tuple, i.e. (0, 10), (0, 9), (0, 8, 2), ...
"""
+ log.info('Probing node %s broker version', self.node_id)
# Monkeypatch some connection configurations to avoid timeouts
override_config = {
'request_timeout_ms': timeout * 1000,
@@ -877,17 +878,6 @@ class BrokerConnection(object):
from kafka.protocol.admin import ApiVersionRequest, ListGroupsRequest
from kafka.protocol.commit import OffsetFetchRequest, GroupCoordinatorRequest
- # Socket errors are logged as exceptions and can alarm users. Mute them
- from logging import Filter
-
- class ConnFilter(Filter):
- def filter(self, record):
- if record.funcName == 'check_version':
- return True
- return False
- log_filter = ConnFilter()
- log.addFilter(log_filter)
-
test_cases = [
# All cases starting from 0.10 will be based on ApiVersionResponse
((0, 10), ApiVersionRequest[0]()),
@@ -967,7 +957,6 @@ class BrokerConnection(object):
else:
raise Errors.UnrecognizedBrokerVersion()
- log.removeFilter(log_filter)
for key in stashed:
self.config[key] = stashed[key]
return version