diff options
| author | David Arthur <mumrah@gmail.com> | 2013-06-25 09:18:31 -0400 |
|---|---|---|
| committer | David Arthur <mumrah@gmail.com> | 2013-06-25 09:18:31 -0400 |
| commit | 7a5eed9f1f3333c0731e5107ee59f7c399aa3bee (patch) | |
| tree | f08fce9f63e8905ed992ca65a2eaca7c30ff1042 | |
| parent | 64b757868a75f47752ec26f7b5d49f84058cea40 (diff) | |
| download | kafka-python-7a5eed9f1f3333c0731e5107ee59f7c399aa3bee.tar.gz | |
Change auto_commit to False in SimpleConsumer
Also start a change log for important stuff like this
Closes #34
| -rw-r--r-- | .gitignore | 1 | ||||
| -rw-r--r-- | CHANGES.md | 3 | ||||
| -rw-r--r-- | kafka/consumer.py | 2 |
3 files changed, 5 insertions, 1 deletions
@@ -4,3 +4,4 @@ build dist MANIFEST +env diff --git a/CHANGES.md b/CHANGES.md new file mode 100644 index 0000000..c795866 --- /dev/null +++ b/CHANGES.md @@ -0,0 +1,3 @@ +# Notable Changes + +* Changing auto_commit to False in [SimpleConsumer](kafka/SimpleConsumer.py), until 0.8.1 is release offset commits are unsupported diff --git a/kafka/consumer.py b/kafka/consumer.py index f8855dc..db7a793 100644 --- a/kafka/consumer.py +++ b/kafka/consumer.py @@ -38,7 +38,7 @@ class SimpleConsumer(object): these triggers """ - def __init__(self, client, group, topic, auto_commit=True, + def __init__(self, client, group, topic, auto_commit=False, auto_commit_every_n=AUTO_COMMIT_MSG_COUNT, auto_commit_every_t=AUTO_COMMIT_INTERVAL): self.client = client |