summaryrefslogtreecommitdiff
path: root/kafka/protocol/legacy.py
diff options
context:
space:
mode:
authorJeff Widman <jeff@jeffwidman.com>2018-11-17 01:37:15 -0800
committerJeff Widman <jeff@jeffwidman.com>2018-11-18 00:20:55 -0800
commitf3105a434f3bd2fb3f8899e4861e187e786b03da (patch)
tree7b7edf67ddd79f9ef63b399c05adb776790e5e12 /kafka/protocol/legacy.py
parent7bd6b5da6d402565f25fce9e710be26b2d4cc125 (diff)
downloadkafka-python-f3105a434f3bd2fb3f8899e4861e187e786b03da.tar.gz
Stop using broker-errors for client-side problems
`UnsupportedVersionError` is intended to indicate a server-side error: https://github.com/dpkp/kafka-python/blob/ba7372e44ffa1ee49fb4d5efbd67534393e944db/kafka/errors.py#L375-L378 So we should not be raising it for client-side errors. I realize that semantically this seems like the appropriate error to raise. However, this is confusing when debugging... for a real-life example, see https://github.com/Parsely/pykafka/issues/697. So I strongly feel that server-side errors should be kept separate from client-side errors, even if all the client is doing is proactively protecting against hitting a situation where the broker would return this error.
Diffstat (limited to 'kafka/protocol/legacy.py')
0 files changed, 0 insertions, 0 deletions