diff options
author | Jeff Widman <jeff@jeffwidman.com> | 2018-11-17 02:56:55 -0800 |
---|---|---|
committer | Jeff Widman <jeff@jeffwidman.com> | 2018-11-17 16:35:46 -0800 |
commit | 02b9798d23d3566fd8298a4d978d6620489ba263 (patch) | |
tree | d60ba5071a5ad4922a851c0a2d431713abe7bb46 /kafka | |
parent | 7bd6b5da6d402565f25fce9e710be26b2d4cc125 (diff) | |
download | kafka-python-dont-support-api-version-strings.tar.gz |
Remove support for api versions as strings from KafkaAdmindont-support-api-version-strings
This is a new class, so let's not support the old version strings and
saddle ourselves with tech debt right from the get-go.
Diffstat (limited to 'kafka')
-rw-r--r-- | kafka/admin/kafka.py | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/kafka/admin/kafka.py b/kafka/admin/kafka.py index fbbbcc2..eb3150e 100644 --- a/kafka/admin/kafka.py +++ b/kafka/admin/kafka.py @@ -171,16 +171,6 @@ class KafkaAdmin(object): self.config = copy.copy(self.DEFAULT_CONFIG) self.config.update(configs) - # api_version was previously a str. accept old format for now - if isinstance(self.config['api_version'], str): - deprecated = self.config['api_version'] - if deprecated == 'auto': - self.config['api_version'] = None - else: - self.config['api_version'] = tuple(map(int, deprecated.split('.'))) - log.warning('use api_version=%s [tuple] -- "%s" as str is deprecated', - str(self.config['api_version']), deprecated) - # Configure metrics metrics_tags = {'client-id': self.config['client_id']} metric_config = MetricConfig(samples=self.config['metrics_num_samples'], |