diff options
author | Jeff Widman <jeff@jeffwidman.com> | 2019-08-22 01:15:35 -0700 |
---|---|---|
committer | Jeff Widman <jeff@jeffwidman.com> | 2019-08-22 01:25:45 -0700 |
commit | bc87474632637dee3e09a878f91ee6ff38e3a8bd (patch) | |
tree | 82f0f218064cd8163addc43042a71207e86cadc9 /test/service.py | |
parent | e49caeb3ebdd36eb4d18a517bc402f8e89dfdbee (diff) | |
download | kafka-python-simplify-version-checking-using-pytest-skipif.tar.gz |
Cleanup handling of KAFKA_VERSION env var in testssimplify-version-checking-using-pytest-skipif
Now that we are using `pytest`, there is no need for a custom decorator
because we can use `pytest.mark.skipif()`.
This makes the code significantly simpler. In particular, dropping the
custom `@kafka_versions()` decorator is necessary because it uses
`func.wraps()` which doesn't play nice with `pytest` fixtures:
- https://github.com/pytest-dev/pytest/issues/677
- https://stackoverflow.com/a/19614807/770425
So this is a pre-requisite to migrating some of those tests to using
pytest fixtures.
Diffstat (limited to 'test/service.py')
0 files changed, 0 insertions, 0 deletions