summaryrefslogtreecommitdiff
path: root/test/test_client_async.py
diff options
context:
space:
mode:
authorDana Powers <dana.powers@gmail.com>2017-08-06 17:49:38 -0700
committerDana Powers <dana.powers@gmail.com>2017-08-13 20:00:59 -0700
commit77c1818a080b62704e8f406d5418345f73053409 (patch)
tree984f25de6693e0b5354c801a4a3590bfcb760577 /test/test_client_async.py
parent497ded919356038d57e935850346ff347b8ea6ef (diff)
downloadkafka-python-no_sleep.tar.gz
Drop unused sleep kwarg to pollno_sleep
Diffstat (limited to 'test/test_client_async.py')
-rw-r--r--test/test_client_async.py33
1 files changed, 16 insertions, 17 deletions
diff --git a/test/test_client_async.py b/test/test_client_async.py
index d4e6d37..ec45543 100644
--- a/test/test_client_async.py
+++ b/test/test_client_async.py
@@ -259,23 +259,22 @@ def test_poll(mocker):
metadata.return_value = 1000
tasks.return_value = 2
cli.poll()
- _poll.assert_called_with(1.0, sleep=True)
+ _poll.assert_called_with(1.0)
# user timeout wins
cli.poll(250)
- _poll.assert_called_with(0.25, sleep=True)
+ _poll.assert_called_with(0.25)
# tasks timeout wins
tasks.return_value = 0
cli.poll(250)
- _poll.assert_called_with(0, sleep=True)
+ _poll.assert_called_with(0)
# default is request_timeout_ms
metadata.return_value = 1000000
tasks.return_value = 10000
cli.poll()
- _poll.assert_called_with(cli.config['request_timeout_ms'] / 1000.0,
- sleep=True)
+ _poll.assert_called_with(cli.config['request_timeout_ms'] / 1000.0)
def test__poll():
@@ -337,8 +336,8 @@ def client(mocker):
def test_maybe_refresh_metadata_ttl(mocker, client):
client.cluster.ttl.return_value = 1234
- client.poll(timeout_ms=12345678, sleep=True)
- client._poll.assert_called_with(1.234, sleep=True)
+ client.poll(timeout_ms=12345678)
+ client._poll.assert_called_with(1.234)
def test_maybe_refresh_metadata_backoff(mocker, client):
@@ -346,15 +345,15 @@ def test_maybe_refresh_metadata_backoff(mocker, client):
t = mocker.patch('time.time')
t.return_value = now
- client.poll(timeout_ms=12345678, sleep=True)
- client._poll.assert_called_with(2.222, sleep=True) # reconnect backoff
+ client.poll(timeout_ms=12345678)
+ client._poll.assert_called_with(2.222) # reconnect backoff
def test_maybe_refresh_metadata_in_progress(mocker, client):
client._metadata_refresh_in_progress = True
- client.poll(timeout_ms=12345678, sleep=True)
- client._poll.assert_called_with(9999.999, sleep=True) # request_timeout_ms
+ client.poll(timeout_ms=12345678)
+ client._poll.assert_called_with(9999.999) # request_timeout_ms
def test_maybe_refresh_metadata_update(mocker, client):
@@ -362,8 +361,8 @@ def test_maybe_refresh_metadata_update(mocker, client):
mocker.patch.object(client, '_can_send_request', return_value=True)
send = mocker.patch.object(client, 'send')
- client.poll(timeout_ms=12345678, sleep=True)
- client._poll.assert_called_with(9999.999, sleep=True) # request_timeout_ms
+ client.poll(timeout_ms=12345678)
+ client._poll.assert_called_with(9999.999) # request_timeout_ms
assert client._metadata_refresh_in_progress
request = MetadataRequest[0]([])
send.assert_called_once_with('foobar', request)
@@ -379,16 +378,16 @@ def test_maybe_refresh_metadata_cant_send(mocker, client):
t.return_value = now
# first poll attempts connection
- client.poll(timeout_ms=12345678, sleep=True)
- client._poll.assert_called_with(2.222, sleep=True) # reconnect backoff
+ client.poll(timeout_ms=12345678)
+ client._poll.assert_called_with(2.222) # reconnect backoff
client._can_connect.assert_called_once_with('foobar')
client._maybe_connect.assert_called_once_with('foobar')
# poll while connecting should not attempt a new connection
client._connecting.add('foobar')
client._can_connect.reset_mock()
- client.poll(timeout_ms=12345678, sleep=True)
- client._poll.assert_called_with(9999.999, sleep=True) # connection timeout (request timeout)
+ client.poll(timeout_ms=12345678)
+ client._poll.assert_called_with(9999.999) # connection timeout (request timeout)
assert not client._can_connect.called
assert not client._metadata_refresh_in_progress