diff options
| author | Dana Powers <dana.powers@gmail.com> | 2019-04-02 21:27:49 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-04-02 21:27:49 -0700 |
| commit | 91d31494d02ea636a991abb4dfb25dd904eefd45 (patch) | |
| tree | 5fa58d3648afc1335cc03facf08255da85416267 /test/test_client_async.py | |
| parent | 27cd93be3e7f2e3f3baca04d2126cf3bb6374668 (diff) | |
| download | kafka-python-91d31494d02ea636a991abb4dfb25dd904eefd45.tar.gz | |
Do not call state_change_callback with lock (#1775)
Diffstat (limited to 'test/test_client_async.py')
| -rw-r--r-- | test/test_client_async.py | 21 |
1 files changed, 11 insertions, 10 deletions
diff --git a/test/test_client_async.py b/test/test_client_async.py index 0951cb4..2132c8e 100644 --- a/test/test_client_async.py +++ b/test/test_client_async.py @@ -95,28 +95,29 @@ def test_conn_state_change(mocker, cli, conn): node_id = 0 cli._conns[node_id] = conn conn.state = ConnectionStates.CONNECTING - cli._conn_state_change(node_id, conn) + sock = conn._sock + cli._conn_state_change(node_id, sock, conn) assert node_id in cli._connecting - sel.register.assert_called_with(conn._sock, selectors.EVENT_WRITE) + sel.register.assert_called_with(sock, selectors.EVENT_WRITE) conn.state = ConnectionStates.CONNECTED - cli._conn_state_change(node_id, conn) + cli._conn_state_change(node_id, sock, conn) assert node_id not in cli._connecting - sel.modify.assert_called_with(conn._sock, selectors.EVENT_READ, conn) + sel.modify.assert_called_with(sock, selectors.EVENT_READ, conn) # Failure to connect should trigger metadata update assert cli.cluster._need_update is False - conn.state = ConnectionStates.DISCONNECTING - cli._conn_state_change(node_id, conn) + conn.state = ConnectionStates.DISCONNECTED + cli._conn_state_change(node_id, sock, conn) assert node_id not in cli._connecting assert cli.cluster._need_update is True - sel.unregister.assert_called_with(conn._sock) + sel.unregister.assert_called_with(sock) conn.state = ConnectionStates.CONNECTING - cli._conn_state_change(node_id, conn) + cli._conn_state_change(node_id, sock, conn) assert node_id in cli._connecting - conn.state = ConnectionStates.DISCONNECTING - cli._conn_state_change(node_id, conn) + conn.state = ConnectionStates.DISCONNECTED + cli._conn_state_change(node_id, sock, conn) assert node_id not in cli._connecting |