summaryrefslogtreecommitdiff
path: root/test/test_failover_integration.py
diff options
context:
space:
mode:
authorJeff Widman <jeff@jeffwidman.com>2018-05-10 16:12:19 -0700
committerJeff Widman <jeff@jeffwidman.com>2018-05-23 15:19:01 -0700
commit11cf3973bfc64ab0b4e471fc56dae911df1ec8d9 (patch)
tree474937a8c01bb32a3b12a944d9a9ad6b32d81800 /test/test_failover_integration.py
parent9221fcf83528b5c3657e43636cb84c1d18025acd (diff)
downloadkafka-python-11cf3973bfc64ab0b4e471fc56dae911df1ec8d9.tar.gz
Stop shadowing `ConnectionError`
In Python3, `ConnectionError` is a native exception. So rename our custom one to `KafkaConnectionError` to prevent accidentally shadowing the native one. Note that there are still valid uses of `ConnectionError` in this code. They already expect a native Python3 `ConnectionError`, and also already handle the Python2 compatibility issues.
Diffstat (limited to 'test/test_failover_integration.py')
-rw-r--r--test/test_failover_integration.py6
1 files changed, 3 insertions, 3 deletions
diff --git a/test/test_failover_integration.py b/test/test_failover_integration.py
index 797e1c8..ad7dcb9 100644
--- a/test/test_failover_integration.py
+++ b/test/test_failover_integration.py
@@ -4,7 +4,7 @@ import time
from kafka import SimpleClient, SimpleConsumer, KeyedProducer
from kafka.errors import (
- FailedPayloadsError, ConnectionError, RequestTimedOutError,
+ FailedPayloadsError, KafkaConnectionError, RequestTimedOutError,
NotLeaderForPartitionError)
from kafka.producer.base import Producer
from kafka.structs import TopicPartition
@@ -79,7 +79,7 @@ class TestFailover(KafkaIntegrationTestCase):
producer.send_messages(topic, partition, b'success')
log.debug("success!")
recovered = True
- except (FailedPayloadsError, ConnectionError, RequestTimedOutError,
+ except (FailedPayloadsError, KafkaConnectionError, RequestTimedOutError,
NotLeaderForPartitionError):
log.debug("caught exception sending message -- will retry")
continue
@@ -167,7 +167,7 @@ class TestFailover(KafkaIntegrationTestCase):
producer.send_messages(topic, key, msg)
if producer.partitioners[topic].partition(key) == 0:
recovered = True
- except (FailedPayloadsError, ConnectionError, RequestTimedOutError,
+ except (FailedPayloadsError, KafkaConnectionError, RequestTimedOutError,
NotLeaderForPartitionError):
log.debug("caught exception sending message -- will retry")
continue