diff options
| author | Jeff Widman <jeff@jeffwidman.com> | 2019-08-22 01:58:28 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-08-22 01:58:28 -0700 |
| commit | 98c005852e36fde0ef44a7b9c60a54f4686651af (patch) | |
| tree | 82f0f218064cd8163addc43042a71207e86cadc9 /test/test_failover_integration.py | |
| parent | e49caeb3ebdd36eb4d18a517bc402f8e89dfdbee (diff) | |
| download | kafka-python-98c005852e36fde0ef44a7b9c60a54f4686651af.tar.gz | |
Cleanup handling of KAFKA_VERSION env var in tests (#1887)
Now that we are using `pytest`, there is no need for a custom decorator
because we can use `pytest.mark.skipif()`.
This makes the code significantly simpler. In particular, dropping the
custom `@kafka_versions()` decorator is necessary because it uses
`func.wraps()` which doesn't play nice with `pytest` fixtures:
- https://github.com/pytest-dev/pytest/issues/677
- https://stackoverflow.com/a/19614807/770425
So this is a pre-requisite to migrating some of those tests to using
pytest fixtures.
Diffstat (limited to 'test/test_failover_integration.py')
| -rw-r--r-- | test/test_failover_integration.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/test_failover_integration.py b/test/test_failover_integration.py index 48021a4..ad7dcb9 100644 --- a/test/test_failover_integration.py +++ b/test/test_failover_integration.py @@ -9,8 +9,8 @@ from kafka.errors import ( from kafka.producer.base import Producer from kafka.structs import TopicPartition -from test.fixtures import ZookeeperFixture, KafkaFixture, random_string -from test.testutil import KafkaIntegrationTestCase +from test.fixtures import ZookeeperFixture, KafkaFixture +from test.testutil import KafkaIntegrationTestCase, random_string log = logging.getLogger(__name__) |