diff options
author | mattip <matti.picus@gmail.com> | 2020-07-28 06:39:16 +0300 |
---|---|---|
committer | mattip <matti.picus@gmail.com> | 2020-07-28 07:09:06 +0300 |
commit | 57fb47cc267eef54005f97d8e55b31df24590093 (patch) | |
tree | ec24bb73eff53ac9531945f151ae7aeb8408da59 | |
parent | 4142eba57b0bde071cb6d0718c88c6ddf7a6e906 (diff) | |
download | numpy-57fb47cc267eef54005f97d8e55b31df24590093.tar.gz |
MAINT: fixes from review
-rwxr-xr-x | setup.py | 8 |
1 files changed, 4 insertions, 4 deletions
@@ -233,6 +233,7 @@ def get_build_overrides(): """ from numpy.distutils.command.build_clib import build_clib from numpy.distutils.command.build_ext import build_ext + from distutils.version import LooseVersion def _is_using_old_gcc(obj): is_old_gcc = False @@ -242,11 +243,10 @@ def get_build_overrides(): out = subprocess.run([cc, '-dumpversion'], stdout=subprocess.PIPE, stderr=subprocess.PIPE, + universal_newlines=True, ) - # will print something like b'4.2.1\n' - ver_parts = out.stdout.split(b'.') - if int(ver_parts[0]) < 6: - # perhaps 5 is OK? + # will print something like '4.2.1\n' + if LooseVersion(out.stdout) < LooseVersion('5.0'): is_old_gcc = True return is_old_gcc |