diff options
author | Sebastian Berg <sebastian@sipsolutions.net> | 2021-01-26 13:07:42 -0600 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-01-26 13:07:42 -0600 |
commit | 7114776a08363a24ae46ea16d659b7b0cdd0c650 (patch) | |
tree | 8398e1e5f8e5c604e621065afc358832eda50748 | |
parent | 08c036c50be6f9bd45b5f07ccc7eca0bfdc77164 (diff) | |
download | numpy-7114776a08363a24ae46ea16d659b7b0cdd0c650.tar.gz |
Apply suggestions from code review
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
-rw-r--r-- | doc/source/release/1.20.0-notes.rst | 7 | ||||
-rw-r--r-- | numpy/__init__.py | 2 |
2 files changed, 4 insertions, 5 deletions
diff --git a/doc/source/release/1.20.0-notes.rst b/doc/source/release/1.20.0-notes.rst index aab5b34a9..453946390 100644 --- a/doc/source/release/1.20.0-notes.rst +++ b/doc/source/release/1.20.0-notes.rst @@ -115,7 +115,7 @@ following alternatives: This ensures that results cannot depend on the computer or operating system. * ``np.int_`` or ``int`` (the default), but be aware that it depends on the computer and operating system. -* The C types: ``np.cint`` (int), ``np.int_`` (long), ``np.longlong``, +* The C types: ``np.cint`` (int), ``np.int_`` (long), ``np.longlong``. * ``np.intp`` which is 32bit on 32bit machines 64bit on 64bit machines. This can be the best type to use for indexing. @@ -127,8 +127,8 @@ If used as a scalar with:: changing it can subtly change the result. In this case, the Python version ``float(123)`` or ``int(12.)`` is normally preferable, although the NumPy -version may be useful for consistency with NumPy arrays. For example, since -NumPy behaves differently for things like division by zero. +version may be useful for consistency with NumPy arrays (for example, +NumPy behaves differently for things like division by zero). (`gh-14882 <https://github.com/numpy/numpy/pull/14882>`__) @@ -1000,4 +1000,3 @@ The former result can still be obtained with:: (`gh-16841 <https://github.com/numpy/numpy/pull/16841>`__) - diff --git a/numpy/__init__.py b/numpy/__init__.py index 01f970345..27b3d33d5 100644 --- a/numpy/__init__.py +++ b/numpy/__init__.py @@ -179,7 +179,7 @@ else: _int_extended_msg = ( "When replacing `np.{}`, you may wish to use e.g. `np.int64` " "or `np.int32` to specify the precision. If you wish to review " - "your current use check the release note link for " + "your current use, check the release note link for " "additional information.") _type_info = [ |