diff options
| author | Sebastian Berg <sebastian@sipsolutions.net> | 2022-04-21 10:36:27 +0200 |
|---|---|---|
| committer | Sebastian Berg <sebastian@sipsolutions.net> | 2022-04-21 10:36:27 +0200 |
| commit | a9ebf19025b18c8e00becea4bdcfd931e8449c19 (patch) | |
| tree | 51a1fbc0d7f4b953d29587b7ee0c68e1b758773f | |
| parent | c900978d5e572d96ccacaa97af28e2c5f4a0b137 (diff) | |
| download | numpy-a9ebf19025b18c8e00becea4bdcfd931e8449c19.tar.gz | |
BUG: Allow legacy dtypes to cast to datetime again
This constraint was added out of a caution with the thought that nobody
uses it. Turns out ora does use it.
In practice, this only affects cast to and from datetimes (or possibly
strings but that seems even less likely).
Tested via ora (see gh-21365) the paths are not particularly special,
but the parametric dtype resolution is in principle missing.
This is not particularly problematic, since NumPy barely exposes that
though, and it never worked.
Closes gh-21365
| -rw-r--r-- | numpy/core/src/multiarray/convert_datatype.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/numpy/core/src/multiarray/convert_datatype.c b/numpy/core/src/multiarray/convert_datatype.c index 09a92b33c..7e10f9b20 100644 --- a/numpy/core/src/multiarray/convert_datatype.c +++ b/numpy/core/src/multiarray/convert_datatype.c @@ -106,9 +106,6 @@ PyArray_GetCastingImpl(PyArray_DTypeMeta *from, PyArray_DTypeMeta *to) return NULL; } else { - if (NPY_DT_is_parametric(from) || NPY_DT_is_parametric(to)) { - Py_RETURN_NONE; - } /* Reject non-legacy dtypes (they need to use the new API) */ if (!NPY_DT_is_legacy(from) || !NPY_DT_is_legacy(to)) { Py_RETURN_NONE; |