diff options
| author | Inessa Pawson <inessapawson@gmail.com> | 2022-06-01 10:42:44 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-01 07:42:44 -0700 |
| commit | c2fc97a2910b078a4f6e0fee80e1b73671f300e6 (patch) | |
| tree | 2a48e6d9f94afcfcec11dfdd23fa638275db5c94 /doc/source/dev | |
| parent | b84d4d04fc91a7b793aafd4b3641af9796d3062c (diff) | |
| download | numpy-c2fc97a2910b078a4f6e0fee80e1b73671f300e6.tar.gz | |
DOC: Add a policy about inactive PRs. (#21537)
Adding a policy about inactive PRs that was approved at the community meeting on March 30th, 2022 (and May 25th, 2022).
* Add a policy about inactive PRs.
* Update doc/source/dev/reviewer_guidelines.rst
Co-authored-by: Rohit Goswami <r95g10@gmail.com>
* Update doc/source/dev/reviewer_guidelines.rst
* Update doc/source/dev/reviewer_guidelines.rst
Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
Diffstat (limited to 'doc/source/dev')
| -rw-r--r-- | doc/source/dev/reviewer_guidelines.rst | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/doc/source/dev/reviewer_guidelines.rst b/doc/source/dev/reviewer_guidelines.rst index ffac85f77..8d938319e 100644 --- a/doc/source/dev/reviewer_guidelines.rst +++ b/doc/source/dev/reviewer_guidelines.rst @@ -91,7 +91,17 @@ For maintainers explain why. If it's not, then it's a good idea to first explain why you think the PR is not suitable for inclusion in NumPy and then let a second committer comment or close. - +- If the PR submitter doesn't respond to your comments for 6 months, move the PR + in question to the inactive category with the “inactive” tag attached. + At this point, the PR can be closed by a maintainer. If there is any interest + in finalizing the PR under consideration, this can be indicated at any time, + without waiting 6 months, by a comment. +- Maintainers are encouraged to finalize PRs when only small changes are + necessary before merging (e.g., fixing code style or grammatical errors). + If a PR becomes inactive, maintainers may make larger changes. + Remember, a PR is a collaboration between a contributor and a reviewer/s, + sometimes a direct push is the best way to finish it. + GitHub Workflow --------------- |