diff options
| author | Gagandeep Singh <gdp.1807@gmail.com> | 2021-07-07 22:00:03 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-07-07 11:30:03 -0500 |
| commit | 6568c6b022e12ab6d71e7548314009ced6ccabe9 (patch) | |
| tree | 27f13e9c8620420fcaea30bc4df30c99b6cd16bf /numpy/array_api/_elementwise_functions.py | |
| parent | d785aa39f99720950cd7f9acfe1133494cb5ff58 (diff) | |
| download | numpy-6568c6b022e12ab6d71e7548314009ced6ccabe9.tar.gz | |
ENH: Adding keepdims to np.argmin,np.argmax (#19211)
* keepdims added to np.argmin,np.argmax
* Added release notes entry
* tested for axis=None,keepdims=True
* Apply suggestions from code review
* updated interface
* updated interface
* API changed, implementation to be done
* Added reshape approach to C implementation
* buggy implementation without reshape
* TestArgMax, TestArgMin fixed, comments added
* Fixed for matrix
* removed unrequired changes
* fixed CI failure
* fixed linting issue
* PyArray_ArgMaxKeepdims now only modifies shape and strides
* Comments added to PyArray_ArgMaxKeepdims
* Updated implementation of PyArray_ArgMinKeepdims to match with PyArray_ArgMaxKeepdims
* Testing complete for PyArray_ArgMinKeepdims and PyArray_ArgMaxKeepdims
* PyArray_ArgMinWithKeepdims both keepdims=True and keepdims=False
* matched implementation of PyArray_ArgMaxKeepdims and PyArray_ArgMinKeepdims
* simplified implementation
* Added missing comment
* removed unwanted header
* addressed all the reviews
* Removing unwanted changes
* fixed docs
* Added new lines
* restored annotations
* parametrized test
* Apply suggestions from code review
Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
* keyword handling now done in np.argmin/np.argmax
* corrected indendation
* used with pytest.riases(ValueError)
* fixed release notes
* removed PyArray_ArgMaxWithKeepdims and PyArray_ArgMinWithKeepdims from public C-API
* Apply suggestions from code review
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
* Apply suggestions from code review
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Diffstat (limited to 'numpy/array_api/_elementwise_functions.py')
0 files changed, 0 insertions, 0 deletions