diff options
author | Ralf Gommers <ralf.gommers@gmail.com> | 2022-02-01 18:26:34 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-02-01 18:26:34 +0100 |
commit | bcdfd208a9b99036cc6e379180c3242b08dedc47 (patch) | |
tree | a946e69e22a96704332177a3b0592b1919c9d58f /numpy/array_api/_manipulation_functions.py | |
parent | c65bc212ec1987caefba0ea7efe6a55803318de9 (diff) | |
download | numpy-bcdfd208a9b99036cc6e379180c3242b08dedc47.tar.gz |
MAINT: f2py: don't generate code that triggers `-Wsometimes-uninitialized` (#20940)
* MAINT: f2py: don't generate code that triggers `-Wsometimes-uninitialized`
Warnings look like:
```
scipy/linalg/_flapackmodule.c:2200:9: warning: variable 'return_value' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (capi_j>capi_i)
^~~~~~~~~~~~~
scipy/linalg/_flapackmodule.c:2217:12: note: uninitialized use occurs here
return return_value;
^~~~~~~~~~~~
scipy/linalg/_flapackmodule.c:2200:5: note: remove the 'if' if its condition is always true
if (capi_j>capi_i)
^~~~~~~~~~~~~~~~~~
scipy/linalg/_flapackmodule.c:2099:21: note: initialize the variable 'return_value' to silence this warning
int return_value;
^
= 0
```
Also:
- Initialize complex return value.
- Warn on non-void callback returning None.
- Use brackets in if-else block.
This makes the code more readable.
Co-authored-by: Pearu Peterson <pearu.peterson@gmail.com>
Diffstat (limited to 'numpy/array_api/_manipulation_functions.py')
0 files changed, 0 insertions, 0 deletions