diff options
| author | Erik M. Bray <embray@stsci.edu> | 2015-10-08 17:33:02 -0400 |
|---|---|---|
| committer | Erik M. Bray <erik.bray@lri.fr> | 2016-05-31 16:30:48 +0200 |
| commit | 0bf907ac5ed0d3c3917cd55d0511633ea8feb8f3 (patch) | |
| tree | ab094fcb6738f818bb3f5bfdd573d13f02a59f35 /numpy/core/_internal.py | |
| parent | e6593fbe72d28929345370696ea292a394795089 (diff) | |
| download | numpy-0bf907ac5ed0d3c3917cd55d0511633ea8feb8f3.tar.gz | |
BUG: Fix numerous bugs related to zero-width string arrays (#473, #1901, #2196, #2585, #4955)
PyArray_NewFromDescr normally does not allow zero-width string dtypes (or rather, it automatically converts them to 1-width strings). This affects any code that uses PyArray_NewFromDescr, which is a lot. So we extend PyArray_NewFromDescr_int to allow disabling this functionality in a couple narrow cases where it's appropriate--one is when extracting a field from a structured array that has a zero-width string dtype (which, intentionally or not, has been allowed). The other, which is related, is returning a view of an array that has a zero-width string dtype. This shouldn't otherwise break or change any existing behavior.
Remove roadblocks to creating structured dtypes with zero-width fields using dict-based constructors (this was possible by other means such as the list-based constructor--with the previous fix in particular it should not be necessary to block this anymore).
Adds tests based on the tests cases given in the issues this is fixing.
Fix a bug with array to zero-width array assignment revealed by the tests. I am slightly concerned that the blunt-force check for this in raw_array_assign_array may be masking a bug somewhere else though.
Diffstat (limited to 'numpy/core/_internal.py')
| -rw-r--r-- | numpy/core/_internal.py | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/numpy/core/_internal.py b/numpy/core/_internal.py index 47c933411..5ad440fa4 100644 --- a/numpy/core/_internal.py +++ b/numpy/core/_internal.py @@ -33,8 +33,6 @@ def _makenames_list(adict, align): if (num < 0): raise ValueError("invalid offset.") format = dtype(obj[0], align=align) - if (format.itemsize == 0): - raise ValueError("all itemsizes must be fixed.") if (n > 2): title = obj[2] else: |