summaryrefslogtreecommitdiff
path: root/numpy/core/arrayprint.py
diff options
context:
space:
mode:
authorAllan Haldane <allan.haldane@gmail.com>2018-02-17 14:36:49 -0500
committerAllan Haldane <allan.haldane@gmail.com>2018-02-18 23:22:01 -0500
commit50fde71f1ac0528f40ee216136b33fde41205ef2 (patch)
tree8027f9c741d643efa82fcd3963dfdc90e14a9428 /numpy/core/arrayprint.py
parent4105af42c38539e8bf854c49134fe221d86ec79d (diff)
downloadnumpy-50fde71f1ac0528f40ee216136b33fde41205ef2.tar.gz
BUG: break cyclic refs in recursive closures
Fixes #10620
Diffstat (limited to 'numpy/core/arrayprint.py')
-rw-r--r--numpy/core/arrayprint.py19
1 files changed, 12 insertions, 7 deletions
diff --git a/numpy/core/arrayprint.py b/numpy/core/arrayprint.py
index 84943cafc..cbe95f51b 100644
--- a/numpy/core/arrayprint.py
+++ b/numpy/core/arrayprint.py
@@ -772,7 +772,8 @@ def _formatArray(a, format_function, line_width, next_line_prefix,
s += hanging_indent + summary_insert + line_sep
for i in range(trailing_items, 1, -1):
- nested = recurser(index + (-i,), next_hanging_indent, next_width)
+ nested = recurser(index + (-i,), next_hanging_indent,
+ next_width)
s += hanging_indent + nested + line_sep
nested = recurser(index + (-1,), next_hanging_indent, next_width)
@@ -782,12 +783,16 @@ def _formatArray(a, format_function, line_width, next_line_prefix,
s = '[' + s[len(hanging_indent):] + ']'
return s
- # invoke the recursive part with an initial index and prefix
- return recurser(
- index=(),
- hanging_indent=next_line_prefix,
- curr_width=line_width)
-
+ try:
+ # invoke the recursive part with an initial index and prefix
+ return recurser(index=(),
+ hanging_indent=next_line_prefix,
+ curr_width=line_width)
+ finally:
+ # recursive closures have a cyclic reference to themselves, which
+ # requires gc to collect (gh-10620). To avoid this problem, for
+ # performance and PyPy friendliness, we break the cycle:
+ recurser = None
def _none_or_positive_arg(x, name):
if x is None: