diff options
| author | Eric Wieser <wieser.eric@gmail.com> | 2019-01-30 19:34:58 -0800 |
|---|---|---|
| committer | Eric Wieser <wieser.eric@gmail.com> | 2019-01-30 22:27:55 -0800 |
| commit | 37ba40b7f975f266d24fa916050fa27c88ab9dbf (patch) | |
| tree | 3f79081259ded14d9da97d217f02ded579d6aad6 /numpy/distutils/fcompiler/intel.py | |
| parent | 87d0528e3892f8cd0e22afce360fb465e8e6cedc (diff) | |
| download | numpy-37ba40b7f975f266d24fa916050fa27c88ab9dbf.tar.gz | |
BUG: Do not double-quote arguments passed on to the linker
After the recent patch to CCompiler.spawn, the file-paths no longer need manual quoting - that's handled as needed within subprocess.
This also states our assumption that our paths do not contain commas.
If we care about this, we could adopt the approach used by https://github.com/rust-lang/rust/issues/38795.
Tested for gcc locally by looking at the error messages of `subprocess.check_call(["gcc", r'-Wl,spaces and no quotes'])`
Other fortran compiler changes not tested, but assumed to be broken in the same way.
Fixes #12882
Diffstat (limited to 'numpy/distutils/fcompiler/intel.py')
| -rw-r--r-- | numpy/distutils/fcompiler/intel.py | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/numpy/distutils/fcompiler/intel.py b/numpy/distutils/fcompiler/intel.py index 217eac8fb..51f681274 100644 --- a/numpy/distutils/fcompiler/intel.py +++ b/numpy/distutils/fcompiler/intel.py @@ -23,7 +23,10 @@ class BaseIntelFCompiler(FCompiler): f + '.f', '-o', f + '.o'] def runtime_library_dir_option(self, dir): - return '-Wl,-rpath="%s"' % dir + # TODO: could use -Xlinker here, if it's supported + assert "," not in dir + + return '-Wl,-rpath=%s' % dir class IntelFCompiler(BaseIntelFCompiler): |