summaryrefslogtreecommitdiff
path: root/numpy/distutils/misc_util.py
diff options
context:
space:
mode:
authorSebastian Berg <sebastian@sipsolutions.net>2020-03-07 13:15:26 -0800
committerGitHub <noreply@github.com>2020-03-07 23:15:26 +0200
commit8087e1de04d011f7ce66bf80dbef4a0599b14f7a (patch)
treef9b7edb1047433421d118c7eee302ed56fc05520 /numpy/distutils/misc_util.py
parent2c36dbbd6dd13b449c43dca85493f94022f19f9d (diff)
downloadnumpy-8087e1de04d011f7ce66bf80dbef4a0599b14f7a.tar.gz
MAINT: use list-based APIs to call subprocesses (#15714)
* MAINT: use list-based APIs to call subprocesses * TST, MAINT: add a test for mingw32ccompiler.build_import, clean up lib2def Co-authored-by: Matti Picus <matti.picus@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Diffstat (limited to 'numpy/distutils/misc_util.py')
-rw-r--r--numpy/distutils/misc_util.py5
1 files changed, 2 insertions, 3 deletions
diff --git a/numpy/distutils/misc_util.py b/numpy/distutils/misc_util.py
index ea8128eab..9f9e9f1ac 100644
--- a/numpy/distutils/misc_util.py
+++ b/numpy/distutils/misc_util.py
@@ -1853,8 +1853,7 @@ class Configuration:
"""Return path's SVN revision number.
"""
try:
- output = subprocess.check_output(
- ['svnversion'], shell=True, cwd=path)
+ output = subprocess.check_output(['svnversion'], cwd=path)
except (subprocess.CalledProcessError, OSError):
pass
else:
@@ -1884,7 +1883,7 @@ class Configuration:
"""
try:
output = subprocess.check_output(
- ['hg identify --num'], shell=True, cwd=path)
+ ['hg', 'identify', '--num'], cwd=path)
except (subprocess.CalledProcessError, OSError):
pass
else: