diff options
| author | Ralf Gommers <ralf.gommers@gmail.com> | 2019-09-11 20:30:53 -0700 |
|---|---|---|
| committer | Ralf Gommers <ralf.gommers@gmail.com> | 2019-09-19 08:57:52 +0200 |
| commit | 69bd8010edb30674f39d2fc3b7ae0a1d03b55c23 (patch) | |
| tree | 11f5659aea12ab6a7ba055f099bc1a0dbb0b7ab6 /numpy/tests | |
| parent | acf62f6881afb2f6e0efc9db6acc44c3c8614528 (diff) | |
| download | numpy-69bd8010edb30674f39d2fc3b7ae0a1d03b55c23.tar.gz | |
TST: make xfailed test for modules in public API pass.
Diffstat (limited to 'numpy/tests')
| -rw-r--r-- | numpy/tests/test_public_api.py | 38 |
1 files changed, 35 insertions, 3 deletions
diff --git a/numpy/tests/test_public_api.py b/numpy/tests/test_public_api.py index b6d8a4715..716ddb3e3 100644 --- a/numpy/tests/test_public_api.py +++ b/numpy/tests/test_public_api.py @@ -372,8 +372,39 @@ def test_all_modules_are_expected(): raise AssertionError("Found unexpected modules: {}".format(modnames)) -@pytest.mark.xfail(reason="missing __all__ dicts are messing this up, " - "needs work") +# Stuff that clearly shouldn't be in the API and is detected by the next test +# below +SKIP_LIST = [ + 'numpy.math', + 'numpy.distutils.log.sys', + 'numpy.distutils.system_info.copy', + 'numpy.distutils.system_info.distutils', + 'numpy.distutils.system_info.log', + 'numpy.distutils.system_info.os', + 'numpy.distutils.system_info.platform', + 'numpy.distutils.system_info.re', + 'numpy.distutils.system_info.shutil', + 'numpy.distutils.system_info.subprocess', + 'numpy.distutils.system_info.sys', + 'numpy.distutils.system_info.tempfile', + 'numpy.distutils.system_info.textwrap', + 'numpy.distutils.system_info.warnings', + 'numpy.doc.constants.re', + 'numpy.doc.constants.textwrap', + 'numpy.lib.emath', + 'numpy.lib.math', + 'numpy.matlib.char', + 'numpy.matlib.rec', + 'numpy.matlib.emath', + 'numpy.matlib.math', + 'numpy.matlib.linalg', + 'numpy.matlib.fft', + 'numpy.matlib.random', + 'numpy.matlib.ctypeslib', + 'numpy.matlib.ma' +] + + def test_all_modules_are_expected_2(): """ Method checking all objects. The pkgutil-based method in @@ -412,7 +443,8 @@ def test_all_modules_are_expected_2(): fullobjname = mod_name + '.' + objname if isinstance(getattr(module, objname), types.ModuleType): if is_unexpected(fullobjname): - members.append(fullobjname) + if fullobjname not in SKIP_LIST: + members.append(fullobjname) return members |