summaryrefslogtreecommitdiff
path: root/weave/ext_tools.py
diff options
context:
space:
mode:
authorEric Jones <eric@enthought.com>2002-09-12 06:54:21 +0000
committerEric Jones <eric@enthought.com>2002-09-12 06:54:21 +0000
commitd3a1627631042af2fe74620f5688d9ba99ce87cf (patch)
treebdf84561d807318f74e0ecfaf520a9aca66b74e6 /weave/ext_tools.py
parent6538641ccf3beb2cc304b5ee21365cb44ff6800b (diff)
downloadnumpy-d3a1627631042af2fe74620f5688d9ba99ce87cf.tar.gz
major rewrite of weave.
0. The underlying library code is significantly re-factored and simpler. There used to be a xxx_spec.py and xxx_info.py file for every group of type conversion classes. The spec file held the python code that handled the conversion and the info file had most of the C code templates that were generated. This proved pretty confusing in practice, so the two files have mostly been merged into the spec file. Also, there was quite a bit of code duplication running around. The re-factoring was able to trim the standard conversion code base (excluding blitz and accelerate stuff) by about 40%. This should be a huge maintainability and extensibility win. 1. With multiple months of using Numeric arrays, I've found some of weave's "magic variable" names unwieldy and want to change them. The following are the old declarations for an array x of Float32 type: PyArrayObject* x = convert_to_numpy(...); float* x_data = (float*) x->data; int* _Nx = x->dimensions; int* _Sx = x->strides; int _Dx = x->nd; The new declaration looks like this: PyArrayObject* x_array = convert_to_numpy(...); float* x = (float*) x->data; int* Nx = x->dimensions; int* Sx = x->strides; int Dx = x->nd; This is obviously not backward compatible, and will break some code (including a lot of mine). It also makes inline() code more readable and natural to write. 2. I've switched from CXX to Gordon McMillan's SCXX for list, tuples, and dictionaries. I like CXX pretty well, but its use of advanced C++ (templates, etc.) caused some portability problems. The SCXX library is similar to CXX but doesn't use templates at all. This, like (1) is not an API compatible change and requires repairing existing code. I have also thought about boost python, but it also makes heavy use of templates. Moving to SCXX gets rid of almost all template usage for the standard type converters which should help portability. std::complex and std::string from the STL are the only templates left. Of course blitz still uses templates in a major way so weave.blitz will continue to be hard on compilers. I've actually considered scrapping the C++ classes for list, tuples, and dictionaries, and just fall back to the standard Python C API because the classes are waaay slower than the raw API in many cases. They are also more convenient and less error prone in many cases, so I've decided to stick with them. The PyObject variable will always be made available for variable "x" under the name "py_x" for more speedy operations. You'll definitely want to use these for anything that needs to be speedy. 3. strings are converted to std::string now. I found this to be the most useful type in for strings in my code. Py::String was used previously. 4. There are a number of reference count "errors" in some of the less tested conversion codes such as instance, module, etc. I've cleaned most of these up. I put errors in quotes here because I'm actually not positive that objects passed into "inline" really need reference counting applied to them. The dictionaries passed in by inline() hold references to these objects so it doesn't seem that they could ever be garbage collected inadvertently. Variables used by ext_tools, though, definitely need the reference counting done. I don't think this is a major cost in speed, so it probably isn't worth getting rid of the ref count code. 5. Unicode objects are now supported. This was necessary to support rendering Unicode strings in the freetype wrappers for Chaco. 6. blitz++ was upgraded to the latest CVS. It compiles about twice as fast as the old blitz and looks like it supports a large number of compilers (though only gcc 2.95.3 is tested). Compile times now take about 9 seconds on my 850 MHz PIII laptop.
Diffstat (limited to 'weave/ext_tools.py')
-rw-r--r--weave/ext_tools.py14
1 files changed, 4 insertions, 10 deletions
diff --git a/weave/ext_tools.py b/weave/ext_tools.py
index 4badc0b20..188454cd6 100644
--- a/weave/ext_tools.py
+++ b/weave/ext_tools.py
@@ -115,7 +115,7 @@ class ext_function_from_specs:
dict_code = "if(py_local_dict) \n" \
"{ \n" \
- " Py::Dict local_dict = Py::Dict(py_local_dict); \n" + \
+ " PWODict local_dict = PWODict(py_local_dict); \n" + \
local_dict_code + \
"} \n"
@@ -128,7 +128,7 @@ class ext_function_from_specs:
"\n} \n"
catch_code = "catch(...) \n" \
"{ \n" + \
- " return_val = Py::Null(); \n" \
+ " return_val = NULL; \n" \
" exception_occured = 1; \n" \
"} \n"
@@ -178,17 +178,11 @@ class ext_function(ext_function_from_specs):
ext_function_from_specs.__init__(self,name,code_block,arg_specs)
-import base_info, common_info, cxx_info, scalar_info
+import base_info
class ext_module:
def __init__(self,name,compiler=''):
- standard_info = [common_info.basic_module_info(),
- common_info.file_info(),
- common_info.instance_info(),
- common_info.callable_info(),
- common_info.module_info(),
- cxx_info.cxx_info(),
- scalar_info.scalar_info()]
+ standard_info = converters.standard_info
self.name = name
self.functions = []
self.compiler = compiler