diff options
| -rw-r--r-- | numpy/core/src/umath/loops_exponent_log.dispatch.c.src | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/numpy/core/src/umath/loops_exponent_log.dispatch.c.src b/numpy/core/src/umath/loops_exponent_log.dispatch.c.src index 41e0bf37b..9970ad2ea 100644 --- a/numpy/core/src/umath/loops_exponent_log.dispatch.c.src +++ b/numpy/core/src/umath/loops_exponent_log.dispatch.c.src @@ -149,8 +149,8 @@ fma_get_exponent(__m256 x) __m256 normal_mask = _mm256_cmp_ps(x, _mm256_set1_ps(FLT_MIN), _CMP_GE_OQ); /* - * It is necessary for temp1 to be volatile, a bug in clang optimizes it out which leads - * to an overflow warning in some cases. See https://github.com/numpy/numpy/issues/18005 + * The volatile is probably unnecessary now since we compile clang with + * `-ftrapping-math`: https://github.com/numpy/numpy/issues/18005 */ volatile __m256 temp1 = _mm256_blendv_ps(x, _mm256_set1_ps(0.0f), normal_mask); __m256 temp = _mm256_mul_ps(temp1, two_power_100); @@ -180,8 +180,8 @@ fma_get_mantissa(__m256 x) __m256 normal_mask = _mm256_cmp_ps(x, _mm256_set1_ps(FLT_MIN), _CMP_GE_OQ); /* - * It is necessary for temp1 to be volatile, a bug in clang optimizes it out which leads - * to an overflow warning in some cases. See https://github.com/numpy/numpy/issues/18005 + * The volatile is probably unnecessary now since we compile clang with + * `-ftrapping-math`: https://github.com/numpy/numpy/issues/18005 */ volatile __m256 temp1 = _mm256_blendv_ps(x, _mm256_set1_ps(0.0f), normal_mask); __m256 temp = _mm256_mul_ps(temp1, two_power_100); |