| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are two reasons to want to keep PyArray_ReduceWrapper out of the
public multiarray API:
- Its signature is likely to change if/when masked arrays are added
- It is essentially a wrapper for array->scalar transformations
(*not* just reductions as its name implies -- the whole reason it
is in multiarray.so in the first place is to support count_nonzero,
which is not actually a reduction!). It provides some nice
conveniences (like making it easy to apply such functions to
multiple axes simultaneously), but, we already have a general
mechanism for writing array->scalar transformations -- generalized
ufuncs. We do not want to have two independent, redundant
implementations of this functionality, one in multiarray and one in
umath! So in the long run we should add these nice features to the
generalized ufunc machinery. And in the short run, we shouldn't add
it to the public API and commit ourselves to supporting it.
However, simply removing it from numpy_api.py is not easy, because
this code was used in both multiarray and umath. This commit:
- Moves ReduceWrapper and supporting code to umath/, and makes
appropriate changes (e.g. renaming it to PyUFunc_ReduceWrapper and
cleaning up the header files).
- Reverts numpy.count_nonzero to its previous implementation, so that
it loses the new axis= and keepdims= arguments. This is
unfortunate, but this change isn't so urgent that it's worth tying
our APIs in knots forever. (Perhaps in the future it can become a
generalized ufunc.)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original masked-NA-NEP branch contained a large number of changes
in addition to the core NA support. For example:
- ufunc.__call__ support for where= argument
- nditer support for arbitrary masks (in support of where=)
- ufunc.reduce support for simultaneous reduction over multiple axes
- a new "array assignment API"
- ndarray.diagonal() returning a view in all cases
- bug-fixes in __array_priority__ handling
- datetime test changes
etc. There's no consensus yet on what should be done with the
maskna-related part of this branch, but the rest is generally useful
and uncontroversial, so the goal of this branch is to identify exactly
which code changes are involved in maskna support.
The basic strategy used to create this patch was:
- Remove the new masking-related fields from ndarray, so no arrays
are masked
- Go through and remove all the code that this makes
dead/inaccessible/irrelevant, in a largely mechanical fashion. So
for example, if I saw 'if (PyArray_HASMASK(a)) { ... }' then that
whole block was obviously just dead code if no arrays have masks,
and I removed it. Likewise for function arguments like skipna that
are useless if there aren't any NAs to skip.
This changed the signature of a number of functions that were newly
exposed in the numpy public API. I've removed all such functions from
the public API, since releasing them with the NA-less signature in 1.7
would create pointless compatibility hassles later if and when we add
back the NA-related functionality. Most such functions are removed by
this commit; the exception is PyArray_ReduceWrapper, which requires
more extensive surgery, and will be handled in followup commits.
I also removed the new ndarray.setasflat method. Reason: a comment
noted that the only reason this was added was to allow easier testing
of one branch of PyArray_CopyAsFlat. That branch is now the main
branch, so that isn't an issue. Nonetheless this function is arguably
useful, so perhaps it should have remained, but I judged that since
numpy's API is already hairier than we would like, it's not a good
idea to add extra hair "just in case". (Also AFAICT the test for this
method in test_maskna was actually incorrect, as noted here:
https://github.com/njsmith/numpyNEP/blob/master/numpyNEP.py
so I'm not confident that it ever worked in master, though I haven't
had a chance to follow-up on this.)
I also removed numpy.count_reduce_items, since without skipna it
became trivial.
I believe that these are the only exceptions to the "remove dead code"
strategy.
|
| |\
| |
| | |
ENH: Give digitize left or right open interval option
|
| | | |
|
| | | |
|
| |/
|
|
|
|
|
|
| |
The new argument allows one to search an argsorted array by passing
in the result of argsorting the array as the 'sorter' argument. For
example
searchsorted(a, sorter=a.argsort)
|
| |
|
|
| |
This has been extensively discussed on the mailing list. See #2072.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
friends
Also fix some array() NA mask construction issues and make sure the
base object doesn't collapse past the owner of the NA mask being
viewed in addition to the data.
|
| | |
|
| | |
|
| |
|
|
|
| |
Also add 'keepdims=' parameter to reductions, to support writing of
the np.std function.
|
| |
|
|
|
|
|
| |
This function either cheaply returns the product of the sizes of
all the reduction axes, or counts the number of items which will
be used in a reduction operation when skipna is True. Its purpose
is to make it easy to do functions like np.mean and np.std.
|
| |
|
|
|
| |
It should also have less memory usage for heterogeneous inputs,
because it no longer makes extra copies in that case.
|
| |
|
|
| |
always return a view
|
| | |
|
| | |
|
| |
|
|
| |
empty, and empty_like
|
| |
|
|
| |
discoverable
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
The previous checkin has examples for working with datetime64 objects and
the busdays functions. Edit the docstrings for busdays to harmonize them
with the language used in the examples.
Instead of saying "business days", now say "valid days". The default
valid days are Monday through Friday, business days, but other sets of
valid days are possible.
|
| | |
|
| |
|
|
|
| |
This should allow one to create struct dtype arrays with np.ones
and np.zeros_like.
|
| |
|
|
|
|
|
|
| |
These functions expose masked copying routines, with and without
handling of overlapping data. Also deprecated the np.putmask and
PyArray_PutMask functions, because np.copyto supercedes their
functionality. This will need to be discussed on the list during
the pull request review.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
Also rename the busdaydef parameters to busdaycal parameters. This
change was motivated by Chuck's code review feedback.
|
| |
|
|
| |
review feedback
|
| | |
|
| |
|
|
|
| |
This makes it match the parameter in the array constructor with
the same meaning.
|
| |
|
|
|
| |
These include order=, casting=, subok=. Also added a forcecopy=
parameter to allow skipping of the copy when possible.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
This name was chosen partially based on the previous multi-iter,
which stored an array of iterators, so 'niter' made sense. In the
new nditer, it doesn't, and 'nop' for number of operands seems better.
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
np.zeros_like, and np.ones_like
This way, the sub-type can be avoided if necessary. This helps mitigate,
but doesn't fix, ticket #1753, by allowing "b = np.empty_like(a, subok=False)".
|
| | |
|
| |
|
|
| |
notes
|
| |
|
|
|
| |
If the ldexp/frexp docs belong in ufunc_docsrtings.py, they need an entry in
core/code_generators/generate_umath.py. See #1759.
|
| | |
|
| | |
|
