summaryrefslogtreecommitdiff
path: root/pygerrit/client.py
diff options
context:
space:
mode:
authorDavid Pursehouse <david.pursehouse@sonymobile.com>2012-10-23 20:55:27 +0900
committerDavid Pursehouse <david.pursehouse@sonymobile.com>2012-10-24 10:22:07 +0900
commit2e9da0e6f2db464e811b35bfe6f5f1aa9cec513e (patch)
tree5f51dc87fd0d3436c4206d849c230fefe93954b5 /pygerrit/client.py
parentd51d0b8e7e8d01892ac45ad84142bfb42520e341 (diff)
downloadpygerrit-2e9da0e6f2db464e811b35bfe6f5f1aa9cec513e.tar.gz
Only add query result lines to returned data
Only add JSON lines in the results if they contain "project". Otherwise the "rowCount" line, and anything else, will be included in the results as an empty Change object. Change-Id: Ia4de4ed7970c8f5ba87f5e12dd42ff45b459b047
Diffstat (limited to 'pygerrit/client.py')
-rw-r--r--pygerrit/client.py7
1 files changed, 3 insertions, 4 deletions
diff --git a/pygerrit/client.py b/pygerrit/client.py
index 976681e..cb32b50 100644
--- a/pygerrit/client.py
+++ b/pygerrit/client.py
@@ -76,10 +76,9 @@ class GerritClient(object):
data = decoder.decode(line)
except ValueError, err:
raise GerritError("Query returned invalid data: %s", err)
- if "type" in data:
- if data["type"] == "error":
- raise GerritError("Query error: %s" % data["message"])
- else:
+ if "type" in data and data["type"] == "error":
+ raise GerritError("Query error: %s" % data["message"])
+ elif "project" in data:
results.append(Change(data))
return results