diff options
| author | Rémi Cardona <remi.cardona@polyconseil.fr> | 2019-09-30 18:00:46 +0200 |
|---|---|---|
| committer | Claudiu Popa <pcmanticore@gmail.com> | 2019-10-03 09:30:43 +0200 |
| commit | 05d3e15d9f6978b037943625fe09b9a384ea63c2 (patch) | |
| tree | 8a5e2b4dc75c86af5dba0d8d402342714f070a73 /pylint/checkers/refactoring.py | |
| parent | 8435a39c8f899fc5448cf31fa6201e641ffec8e7 (diff) | |
| download | pylint-git-05d3e15d9f6978b037943625fe09b9a384ea63c2.tar.gz | |
properly handle literals in ``unnecessary-comprehension`` checker, closes #3148
Diffstat (limited to 'pylint/checkers/refactoring.py')
| -rw-r--r-- | pylint/checkers/refactoring.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/pylint/checkers/refactoring.py b/pylint/checkers/refactoring.py index 0d2c6d7a0..7e5a8d140 100644 --- a/pylint/checkers/refactoring.py +++ b/pylint/checkers/refactoring.py @@ -1050,7 +1050,9 @@ class RefactoringChecker(checkers.BaseTokenChecker): if isinstance(expr, astroid.Name): expr_list = expr.name elif isinstance(expr, astroid.Tuple): - expr_list = [elt.name for elt in expr.elts if isinstance(elt, astroid.Name)] + if any(not isinstance(elt, astroid.Name) for elt in expr.elts): + return + expr_list = [elt.name for elt in expr.elts] else: expr_list = [] target = node.parent.generators[0].target |