diff options
| author | Claudiu Popa <pcmanticore@gmail.com> | 2018-07-08 12:02:57 +0200 |
|---|---|---|
| committer | Claudiu Popa <pcmanticore@gmail.com> | 2018-07-08 12:02:57 +0200 |
| commit | 0d4aedafdd474cc503f744241e2d48a188302206 (patch) | |
| tree | 5ac0565df0b2235c5adcd3774aa9de1045ad4abf /pylint/checkers/refactoring.py | |
| parent | 2bac1d98b82fceec29a856d307b37202a2ce98a9 (diff) | |
| download | pylint-git-0d4aedafdd474cc503f744241e2d48a188302206.tar.gz | |
Do not emit consider-using-ternary when all the elements involved are a Compare node (might not be simplifiable to a ternary).
Diffstat (limited to 'pylint/checkers/refactoring.py')
| -rw-r--r-- | pylint/checkers/refactoring.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/pylint/checkers/refactoring.py b/pylint/checkers/refactoring.py index 53ebe6326..fa24169b2 100644 --- a/pylint/checkers/refactoring.py +++ b/pylint/checkers/refactoring.py @@ -708,6 +708,8 @@ class RefactoringChecker(checkers.BaseTokenChecker): suggestion = false_value.as_string() else: message = 'consider-using-ternary' + if all(isinstance(value, astroid.Compare) for value in (truth_value, false_value)): + return suggestion = '{truth} if {cond} else {false}'.format( truth=truth_value.as_string(), cond=cond.as_string(), |