summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Gemmell <robbie@apache.org>2010-09-29 15:22:19 +0000
committerRobert Gemmell <robbie@apache.org>2010-09-29 15:22:19 +0000
commitc50e715ac43286db077635d33d120b27ae1ca924 (patch)
tree337e5dc8d5f334f44f9ed50eaa9e9eeb4bfefc5c
parent1b44286f33d6c2c416765c7e81dffae7b270c7e4 (diff)
downloadqpid-python-c50e715ac43286db077635d33d120b27ae1ca924.tar.gz
QPID-2857: close the input stream used when loading properties files for JNDI lookups
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk/qpid@1002675 13f79535-47bb-0310-9956-ffa450edef68
-rw-r--r--java/client/src/main/java/org/apache/qpid/jndi/PropertiesFileInitialContextFactory.java11
1 files changed, 10 insertions, 1 deletions
diff --git a/java/client/src/main/java/org/apache/qpid/jndi/PropertiesFileInitialContextFactory.java b/java/client/src/main/java/org/apache/qpid/jndi/PropertiesFileInitialContextFactory.java
index f0f9a9840c..fec5af55c1 100644
--- a/java/client/src/main/java/org/apache/qpid/jndi/PropertiesFileInitialContextFactory.java
+++ b/java/client/src/main/java/org/apache/qpid/jndi/PropertiesFileInitialContextFactory.java
@@ -81,10 +81,19 @@ public class PropertiesFileInitialContextFactory implements InitialContextFactor
if (file != null)
{
_logger.info("Loading Properties from:" + file);
+
// Load the properties specified
+ BufferedInputStream inputStream = new BufferedInputStream(new FileInputStream(file));
Properties p = new Properties();
+ try
+ {
+ p.load(inputStream);
+ }
+ finally
+ {
+ inputStream.close();
+ }
- p.load(new BufferedInputStream(new FileInputStream(file)));
Strings.Resolver resolver = new Strings.ChainedResolver
(Strings.SYSTEM_RESOLVER, new Strings.PropertiesResolver(p));