diff options
author | Alan Conway <aconway@apache.org> | 2007-08-16 20:12:33 +0000 |
---|---|---|
committer | Alan Conway <aconway@apache.org> | 2007-08-16 20:12:33 +0000 |
commit | 49c7a491c98c26fe7d4f017a7ba655dfc029278c (patch) | |
tree | 304d51ba039a5391b4ebde08caab3da978b465fb /cpp/rubygen/cppgen.rb | |
parent | dc13ca80ff893f74ab57fee6543de6543aa366bc (diff) | |
download | qpid-python-49c7a491c98c26fe7d4f017a7ba655dfc029278c.tar.gz |
AMQBodies are no longer allocated on the heap and passed with shared_ptr.
AMQFrame contains a boost::variant of AMQHeaderBody,AMQContentBody,
AMQHeatbeatBody, and MethodHolder. A variant is basically a type-safe
union, it can allocate any of the types in-place.
MethodHolder contains a Blob, a less sophisticated kind of variant,
which can contain any of the concrete method body types.
Using variants for all the method types causes outrageous compile
times and bloated library symbol names. Blob lacks some of the finer
features of variant and needs help from generated code. For now both
are hidden to the rest of the code base behind AMQFrame and MethodBody
classes so if/when we decide to settle on just one "variant" type
solution we can do so.
This commit touches nearly 100 files, mostly converting method
signatures with shared_ptr<FooBody> to FooBody* or FooBody&, and
converting stored shared_ptr<AMQBody> to AMQFrame and
share_ptr<AMQMethodBody> to MethodHolder.
There is one outstanding client memory leak, which I will fix in my next commit.
git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk/qpid@566822 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'cpp/rubygen/cppgen.rb')
-rwxr-xr-x | cpp/rubygen/cppgen.rb | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/cpp/rubygen/cppgen.rb b/cpp/rubygen/cppgen.rb index 724634e514..a3314c7e11 100755 --- a/cpp/rubygen/cppgen.rb +++ b/cpp/rubygen/cppgen.rb @@ -63,6 +63,7 @@ end class AmqpField def cppname() @cache_cppname ||= name.lcaps.cppsafe; end def cpptype() @cache_cpptype ||= amqp_root.param_type(field_type); end + def cppret_type() @cache_cpptype ||= amqp_root.return_type(field_type); end def type_name () @type_name ||= cpptype+" "+cppname; end end @@ -159,8 +160,12 @@ class CppGen < Generator def struct_class(type, name, bases, &block) genl gen "#{type} #{name}" - gen ": #{bases.join(', ')}" unless bases.empty? - scope(" {","};") { yield } + if (!bases.empty?) + genl ":" + indent { gen "#{bases.join(",\n")}" } + end + genl + scope("{","};") { yield } end def struct(name, *bases, &block) struct_class("struct", name, bases, &block); end |