summaryrefslogtreecommitdiff
path: root/cpp/src
diff options
context:
space:
mode:
authorStephen D. Huston <shuston@apache.org>2010-06-17 21:11:24 +0000
committerStephen D. Huston <shuston@apache.org>2010-06-17 21:11:24 +0000
commitdeeabcecf1c252cfb0cc62250b0ff1ee75300f07 (patch)
tree0bf4fa500ef7b1ddfcb683246c5326ef5937b443 /cpp/src
parentac2f86fa29b4033393acbfee4095790eb81ef469 (diff)
downloadqpid-python-deeabcecf1c252cfb0cc62250b0ff1ee75300f07.tar.gz
Consistent comparison of unsigned values; clarify usage as well as removing potential bad compare.
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk/qpid@955749 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'cpp/src')
-rw-r--r--cpp/src/qpid/acl/AclReader.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/cpp/src/qpid/acl/AclReader.cpp b/cpp/src/qpid/acl/AclReader.cpp
index 9a39347399..31c69e69b5 100644
--- a/cpp/src/qpid/acl/AclReader.cpp
+++ b/cpp/src/qpid/acl/AclReader.cpp
@@ -356,7 +356,8 @@ bool AclReader::processGroupLine(tokList& toks, const bool cont) {
addName(toks[i], citr->second);
}
} else {
- if (toksSize < (cont ? 2 : 3)) {
+ const unsigned minimumSize = (cont ? 2 : 3);
+ if (toksSize < minimumSize) {
errorStream << ACL_FORMAT_ERR_LOG_PREFIX << "Line : " << lineNumber
<< ", Insufficient tokens for group definition.";
return false;