summaryrefslogtreecommitdiff
path: root/java/broker-plugins/firewall/src
diff options
context:
space:
mode:
authorMartin Ritchie <ritchiem@apache.org>2010-06-03 21:29:34 +0000
committerMartin Ritchie <ritchiem@apache.org>2010-06-03 21:29:34 +0000
commit69333f9a750d92659799d4f08dd5c52e0393e2c0 (patch)
tree4c58dbf834714faed74d56485a494c0b09ef498d /java/broker-plugins/firewall/src
parent385306d3e315dade5e6366f4f7c9a1fd1c41b482 (diff)
downloadqpid-python-69333f9a750d92659799d4f08dd5c52e0393e2c0.tar.gz
Cleanup code. Configuration security.access is not used anymore
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk/qpid@951167 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'java/broker-plugins/firewall/src')
-rw-r--r--java/broker-plugins/firewall/src/main/java/org/apache/qpid/server/security/access/plugins/FirewallConfiguration.java7
1 files changed, 4 insertions, 3 deletions
diff --git a/java/broker-plugins/firewall/src/main/java/org/apache/qpid/server/security/access/plugins/FirewallConfiguration.java b/java/broker-plugins/firewall/src/main/java/org/apache/qpid/server/security/access/plugins/FirewallConfiguration.java
index 1a2bf62d73..b10656d622 100644
--- a/java/broker-plugins/firewall/src/main/java/org/apache/qpid/server/security/access/plugins/FirewallConfiguration.java
+++ b/java/broker-plugins/firewall/src/main/java/org/apache/qpid/server/security/access/plugins/FirewallConfiguration.java
@@ -91,10 +91,11 @@ public class FirewallConfiguration extends ConfigurationPlugin
_finalConfig.addConfiguration(new XMLConfiguration((String) subFile));
}
- // all rules must have an access attribute
- if (_finalConfig.getList("rule[@access]").size() == 0)
+ // all rules must have an access attribute or a default value
+ if (_finalConfig.getList("rule[@access]").size() == 0 &&
+ _configuration.getString("[@default-action]") == null)
{
- throw new ConfigurationException("No rules found in firewall configuration.");
+ throw new ConfigurationException("No rules or default-action found in firewall configuration.");
}
}