QPID-2322: remove unused version key from the MBean ObjectName's

git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk/qpid@896674 13f79535-47bb-0310-9956-ffa450edef68

12 files changed, 12 insertions, 34 deletions

diff --git a/java/broker/src/main/java/org/apache/qpid/server/AMQBrokerManagerMBean.java b/java/broker/src/main/java/org/apache/qpid/server/AMQBrokerManagerMBean.java
index de1b69b0a4..41ae52e9b8 100644
--- a/java/broker/src/main/java/org/apache/qpid/server/AMQBrokerManagerMBean.java
+++ b/java/broker/src/main/java/org/apache/qpid/server/AMQBrokerManagerMBean.java
@@ -86,7 +86,7 @@ public class AMQBrokerManagerMBean extends AMQManagedObject implements ManagedBr
     @MBeanConstructor("Creates the Broker Manager MBean")
     public AMQBrokerManagerMBean(VirtualHostImpl.VirtualHostMBean virtualHostMBean) throws JMException
     {
-        super(ManagedBroker.class, ManagedBroker.TYPE, ManagedBroker.VERSION);
+        super(ManagedBroker.class, ManagedBroker.TYPE);
 
         _virtualHostMBean = virtualHostMBean;
         VirtualHost virtualHost = virtualHostMBean.getVirtualHost();
diff --git a/java/broker/src/main/java/org/apache/qpid/server/configuration/management/ConfigurationManagementMBean.java b/java/broker/src/main/java/org/apache/qpid/server/configuration/management/ConfigurationManagementMBean.java
index 24f8e8878e..cc402d5b4a 100644
--- a/java/broker/src/main/java/org/apache/qpid/server/configuration/management/ConfigurationManagementMBean.java
+++ b/java/broker/src/main/java/org/apache/qpid/server/configuration/management/ConfigurationManagementMBean.java
@@ -32,7 +32,7 @@ public class ConfigurationManagementMBean extends AMQManagedObject implements Co
 
     public ConfigurationManagementMBean() throws NotCompliantMBeanException
     {
-        super(ConfigurationManagement.class, ConfigurationManagement.TYPE, ConfigurationManagement.VERSION);
+        super(ConfigurationManagement.class, ConfigurationManagement.TYPE);
     }
 
     public String getObjectInstanceName()
diff --git a/java/broker/src/main/java/org/apache/qpid/server/exchange/AbstractExchange.java b/java/broker/src/main/java/org/apache/qpid/server/exchange/AbstractExchange.java
index 33af910f1a..07f33b4a8f 100644
--- a/java/broker/src/main/java/org/apache/qpid/server/exchange/AbstractExchange.java
+++ b/java/broker/src/main/java/org/apache/qpid/server/exchange/AbstractExchange.java
@@ -90,7 +90,7 @@ public abstract class AbstractExchange implements Exchange, Managable
 
         public ExchangeMBean() throws NotCompliantMBeanException
         {
-            super(ManagedExchange.class, ManagedExchange.TYPE, ManagedExchange.VERSION);
+            super(ManagedExchange.class, ManagedExchange.TYPE);
         }
 
         protected void init() throws OpenDataException
diff --git a/java/broker/src/main/java/org/apache/qpid/server/information/management/ServerInformationMBean.java b/java/broker/src/main/java/org/apache/qpid/server/information/management/ServerInformationMBean.java
index 6247404d90..db2cc970b2 100644
--- a/java/broker/src/main/java/org/apache/qpid/server/information/management/ServerInformationMBean.java
+++ b/java/broker/src/main/java/org/apache/qpid/server/information/management/ServerInformationMBean.java
@@ -37,7 +37,7 @@ public class ServerInformationMBean extends AMQManagedObject implements ServerIn
     
     public ServerInformationMBean(String buildVersion, String productVersion) throws JMException
     {
-        super(ServerInformation.class, ServerInformation.TYPE, ServerInformation.VERSION);
+        super(ServerInformation.class, ServerInformation.TYPE);
         this.buildVersion = buildVersion;
         this.productVersion = productVersion;
     }
diff --git a/java/broker/src/main/java/org/apache/qpid/server/logging/management/LoggingManagementMBean.java b/java/broker/src/main/java/org/apache/qpid/server/logging/management/LoggingManagementMBean.java
index c36eeb5016..36e8f6cf84 100644
--- a/java/broker/src/main/java/org/apache/qpid/server/logging/management/LoggingManagementMBean.java
+++ b/java/broker/src/main/java/org/apache/qpid/server/logging/management/LoggingManagementMBean.java
@@ -109,7 +109,7 @@ public class LoggingManagementMBean extends AMQManagedObject implements LoggingM
     
     public LoggingManagementMBean(String log4jConfigFileName, int log4jLogWatchInterval) throws JMException
     {
-        super(LoggingManagement.class, LoggingManagement.TYPE, LoggingManagement.VERSION);
+        super(LoggingManagement.class, LoggingManagement.TYPE);
         _log4jConfigFileName = log4jConfigFileName;
         _log4jLogWatchInterval = log4jLogWatchInterval;
     }
diff --git a/java/broker/src/main/java/org/apache/qpid/server/management/AMQManagedObject.java b/java/broker/src/main/java/org/apache/qpid/server/management/AMQManagedObject.java
index 594ae24502..c4ffcd26bf 100644
--- a/java/broker/src/main/java/org/apache/qpid/server/management/AMQManagedObject.java
+++ b/java/broker/src/main/java/org/apache/qpid/server/management/AMQManagedObject.java
@@ -56,10 +56,10 @@ public abstract class AMQManagedObject extends DefaultManagedObject
 
     protected LogActor _logActor;
 
-    protected AMQManagedObject(Class<?> managementInterface, String typeName, int version)
+    protected AMQManagedObject(Class<?> managementInterface, String typeName)
         throws NotCompliantMBeanException
     {
-        super(managementInterface, typeName, version);
+        super(managementInterface, typeName);
         // CurrentActor will be defined as these objects are created during
         // broker startup.
         _logActor = new ManagementActor(CurrentActor.get().getRootMessageLogger());
diff --git a/java/broker/src/main/java/org/apache/qpid/server/management/DefaultManagedObject.java b/java/broker/src/main/java/org/apache/qpid/server/management/DefaultManagedObject.java
index d72b8f24ec..0a739af695 100644
--- a/java/broker/src/main/java/org/apache/qpid/server/management/DefaultManagedObject.java
+++ b/java/broker/src/main/java/org/apache/qpid/server/management/DefaultManagedObject.java
@@ -39,15 +39,13 @@ public abstract class DefaultManagedObject extends StandardMBean implements Mana
     private Class<?> _managementInterface;
 
     private String _typeName;
-    private int _version;
 
-    protected DefaultManagedObject(Class<?> managementInterface, String typeName, int version)
+    protected DefaultManagedObject(Class<?> managementInterface, String typeName)
         throws NotCompliantMBeanException
     {
         super(managementInterface);
         _managementInterface = managementInterface;
         _typeName = typeName;
-        _version = version;
     }
 
     public String getType()
@@ -110,10 +108,6 @@ public abstract class DefaultManagedObject extends StandardMBean implements Mana
         objectName.append(getHierarchicalName(this));
         objectName.append("name=").append(name);
 
-        objectName.append(",");
-        objectName.append("version=").append(_version);
-
-
         return new ObjectName(objectName.toString());
     }
 
@@ -131,9 +125,6 @@ public abstract class DefaultManagedObject extends StandardMBean implements Mana
             objectName.append(hierarchyName.substring(0, hierarchyName.lastIndexOf(",")));
         }
 
-        objectName.append(",");
-        objectName.append("version=").append(_version);
-
         return new ObjectName(objectName.toString());
     }
 
diff --git a/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolSessionMBean.java b/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolSessionMBean.java
index 72788bdb0f..0562d04b7b 100644
--- a/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolSessionMBean.java
+++ b/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolSessionMBean.java
@@ -94,7 +94,7 @@ public class AMQProtocolSessionMBean extends AMQManagedObject implements Managed
     @MBeanConstructor("Creates an MBean exposing an AMQ Broker Connection")
     public AMQProtocolSessionMBean(AMQProtocolSession amqProtocolSession) throws NotCompliantMBeanException, OpenDataException
     {
-        super(ManagedConnection.class, ManagedConnection.TYPE, ManagedConnection.VERSION);
+        super(ManagedConnection.class, ManagedConnection.TYPE);
         _protocolSession = amqProtocolSession;
         String remote = getRemoteAddress();
         remote = "anonymous".equals(remote) ? (remote + hashCode()) : remote;
diff --git a/java/broker/src/main/java/org/apache/qpid/server/queue/AMQQueueMBean.java b/java/broker/src/main/java/org/apache/qpid/server/queue/AMQQueueMBean.java
index 021128d2fc..c21d73cc41 100644
--- a/java/broker/src/main/java/org/apache/qpid/server/queue/AMQQueueMBean.java
+++ b/java/broker/src/main/java/org/apache/qpid/server/queue/AMQQueueMBean.java
@@ -93,7 +93,7 @@ public class AMQQueueMBean extends AMQManagedObject implements ManagedQueue, Que
     @MBeanConstructor("Creates an MBean exposing an AMQQueue")
     public AMQQueueMBean(AMQQueue queue) throws JMException
     {
-        super(ManagedQueue.class, ManagedQueue.TYPE, ManagedQueue.VERSION);
+        super(ManagedQueue.class, ManagedQueue.TYPE);
         _queue = queue;
         _queueName = jmxEncode(new StringBuffer(queue.getName()), 0).toString();
     }
diff --git a/java/broker/src/main/java/org/apache/qpid/server/security/access/management/AMQUserManagementMBean.java b/java/broker/src/main/java/org/apache/qpid/server/security/access/management/AMQUserManagementMBean.java
index 69abac7bd6..45ab57ca90 100644
--- a/java/broker/src/main/java/org/apache/qpid/server/security/access/management/AMQUserManagementMBean.java
+++ b/java/broker/src/main/java/org/apache/qpid/server/security/access/management/AMQUserManagementMBean.java
@@ -100,7 +100,7 @@ public class AMQUserManagementMBean extends AMQManagedObject implements UserMana
 
     public AMQUserManagementMBean() throws JMException
     {
-        super(UserManagement.class, UserManagement.TYPE, UserManagement.VERSION);
+        super(UserManagement.class, UserManagement.TYPE);
     }
 
     public String getObjectInstanceName()
diff --git a/java/broker/src/main/java/org/apache/qpid/server/virtualhost/VirtualHostImpl.java b/java/broker/src/main/java/org/apache/qpid/server/virtualhost/VirtualHostImpl.java
index 48581c0290..2f1528eb43 100644
--- a/java/broker/src/main/java/org/apache/qpid/server/virtualhost/VirtualHostImpl.java
+++ b/java/broker/src/main/java/org/apache/qpid/server/virtualhost/VirtualHostImpl.java
@@ -121,7 +121,7 @@ public class VirtualHostImpl implements Accessable, VirtualHost
     {
         public VirtualHostMBean() throws NotCompliantMBeanException
         {
-            super(ManagedVirtualHost.class, ManagedVirtualHost.TYPE, ManagedVirtualHost.VERSION);
+            super(ManagedVirtualHost.class, ManagedVirtualHost.TYPE);
         }
 
         public String getObjectInstanceName()
diff --git a/java/broker/src/test/java/org/apache/qpid/server/security/access/management/AMQUserManagementMBeanTest.java b/java/broker/src/test/java/org/apache/qpid/server/security/access/management/AMQUserManagementMBeanTest.java
index dab98095c9..fe35cfa3aa 100644
--- a/java/broker/src/test/java/org/apache/qpid/server/security/access/management/AMQUserManagementMBeanTest.java
+++ b/java/broker/src/test/java/org/apache/qpid/server/security/access/management/AMQUserManagementMBeanTest.java
@@ -160,19 +160,6 @@ public class AMQUserManagementMBeanTest extends TestCase
         }
     }
 
-    public void testMBeanVersion()
-    {
-        try
-        {
-            ObjectName name = _amqumMBean.getObjectName();
-            assertEquals(AMQUserManagementMBean.VERSION, Integer.parseInt(name.getKeyProperty("version")));
-        }
-        catch (MalformedObjectNameException e)
-        {
-            fail(e.getMessage());
-        }
-    }
-
     public void testSetAccessFileWithMissingFile()
     {
         try