diff options
| author | Robert Gemmell <robbie@apache.org> | 2010-09-18 21:19:18 +0000 |
|---|---|---|
| committer | Robert Gemmell <robbie@apache.org> | 2010-09-18 21:19:18 +0000 |
| commit | aae7cfee492d3f245a0797211bbfd28ae1017eec (patch) | |
| tree | 53700574a1c5e7ac96a6a4fe13f97f0595190f10 /java | |
| parent | f3c426e27d4cded63a2eeb34ec5e6a8d4b803589 (diff) | |
| download | qpid-python-aae7cfee492d3f245a0797211bbfd28ae1017eec.tar.gz | |
QPID-2868: guard against non-existent destinations when moving/copying
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk/qpid@998547 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'java')
| -rw-r--r-- | java/broker/src/main/java/org/apache/qpid/server/queue/SimpleAMQQueue.java | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/java/broker/src/main/java/org/apache/qpid/server/queue/SimpleAMQQueue.java b/java/broker/src/main/java/org/apache/qpid/server/queue/SimpleAMQQueue.java index 112f682fdc..6fece81e88 100644 --- a/java/broker/src/main/java/org/apache/qpid/server/queue/SimpleAMQQueue.java +++ b/java/broker/src/main/java/org/apache/qpid/server/queue/SimpleAMQQueue.java @@ -1106,11 +1106,14 @@ public class SimpleAMQQueue implements AMQQueue, Subscription.StateListener public void moveMessagesToAnotherQueue(final long fromMessageId, final long toMessageId, String queueName, - ServerTransaction txn) + ServerTransaction txn) throws IllegalArgumentException { final AMQQueue toQueue = getVirtualHost().getQueueRegistry().getQueue(new AMQShortString(queueName)); - + if (toQueue == null) + { + throw new IllegalArgumentException("Queue '" + queueName + "' is not registered with the virtualhost."); + } List<QueueEntry> entries = getMessagesOnTheQueue(new QueueEntryFilter() { @@ -1178,9 +1181,13 @@ public class SimpleAMQQueue implements AMQQueue, Subscription.StateListener public void copyMessagesToAnotherQueue(final long fromMessageId, final long toMessageId, String queueName, - final ServerTransaction txn) + final ServerTransaction txn) throws IllegalArgumentException { final AMQQueue toQueue = getVirtualHost().getQueueRegistry().getQueue(new AMQShortString(queueName)); + if (toQueue == null) + { + throw new IllegalArgumentException("Queue '" + queueName + "' is not registered with the virtualhost."); + } List<QueueEntry> entries = getMessagesOnTheQueue(new QueueEntryFilter() { |
