diff options
| author | Gordon Sim <gsim@apache.org> | 2013-08-16 22:15:06 +0000 |
|---|---|---|
| committer | Gordon Sim <gsim@apache.org> | 2013-08-16 22:15:06 +0000 |
| commit | 478ada4d28ea56aad643518cc019ee81bba80a73 (patch) | |
| tree | 0ea961f61e3ad6a2d5d8987dcfc06d861d6f76e2 /qpid/cpp/src | |
| parent | 88ca352ffee7df7e037bed1e73936e9b5d9b9ae2 (diff) | |
| download | qpid-python-478ada4d28ea56aad643518cc019ee81bba80a73.tar.gz | |
QPID-5078: ensure listeners are always notified if a message was left on the queue
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1514907 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'qpid/cpp/src')
| -rw-r--r-- | qpid/cpp/src/qpid/broker/Queue.cpp | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/qpid/cpp/src/qpid/broker/Queue.cpp b/qpid/cpp/src/qpid/broker/Queue.cpp index 227acd1b56..e96ebd3701 100644 --- a/qpid/cpp/src/qpid/broker/Queue.cpp +++ b/qpid/cpp/src/qpid/broker/Queue.cpp @@ -393,6 +393,7 @@ bool Queue::getNextMessage(Message& m, Consumer::shared_ptr& c) if (!checkNotDeleted(c)) return false; QueueListeners::NotificationSet set; ScopedAutoDelete autodelete(*this); + bool messageFound(false); while (true) { //TODO: reduce lock scope Mutex::ScopedLock locker(messageLock); @@ -434,7 +435,8 @@ bool Queue::getNextMessage(Message& m, Consumer::shared_ptr& c) QPID_LOG(debug, "Message " << msg->getSequence() << " retrieved from '" << name << "'"); m = *msg; - return true; + messageFound = true; + break; } else { //message(s) are available but consumer hasn't got enough credit QPID_LOG(debug, "Consumer can't currently accept message from '" << name << "'"); @@ -456,11 +458,12 @@ bool Queue::getNextMessage(Message& m, Consumer::shared_ptr& c) } else { QPID_LOG(debug, "No messages to dispatch on queue '" << name << "'"); listeners.addListener(c); - return false; + break; } + } set.notify(); - return false; + return messageFound; } void Queue::removeListener(Consumer::shared_ptr c) |