summaryrefslogtreecommitdiff
path: root/qpid/cpp/src
diff options
context:
space:
mode:
authorStephen D. Huston <shuston@apache.org>2010-06-17 21:11:24 +0000
committerStephen D. Huston <shuston@apache.org>2010-06-17 21:11:24 +0000
commitea9f51d7bc6a0e20050ac4af2f1135f839d386ec (patch)
treed42dbc4fdb3e65da893596672a0dc84fef5c6964 /qpid/cpp/src
parent7d3d3ebbccd46451f19d7a80e68e11dde7ae139f (diff)
downloadqpid-python-ea9f51d7bc6a0e20050ac4af2f1135f839d386ec.tar.gz
Consistent comparison of unsigned values; clarify usage as well as removing potential bad compare.
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@955749 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'qpid/cpp/src')
-rw-r--r--qpid/cpp/src/qpid/acl/AclReader.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/qpid/cpp/src/qpid/acl/AclReader.cpp b/qpid/cpp/src/qpid/acl/AclReader.cpp
index 9a39347399..31c69e69b5 100644
--- a/qpid/cpp/src/qpid/acl/AclReader.cpp
+++ b/qpid/cpp/src/qpid/acl/AclReader.cpp
@@ -356,7 +356,8 @@ bool AclReader::processGroupLine(tokList& toks, const bool cont) {
addName(toks[i], citr->second);
}
} else {
- if (toksSize < (cont ? 2 : 3)) {
+ const unsigned minimumSize = (cont ? 2 : 3);
+ if (toksSize < minimumSize) {
errorStream << ACL_FORMAT_ERR_LOG_PREFIX << "Line : " << lineNumber
<< ", Insufficient tokens for group definition.";
return false;