summaryrefslogtreecommitdiff
path: root/qpid/cpp/src
diff options
context:
space:
mode:
authorGordon Sim <gsim@apache.org>2013-10-31 14:09:12 +0000
committerGordon Sim <gsim@apache.org>2013-10-31 14:09:12 +0000
commitf0f982abaa645bcf1036ee963498cd6fd5a2fa79 (patch)
treea75d3edc43aca2019d35bc5281e3232dcd78b871 /qpid/cpp/src
parent9b1bf6023a9869af744e2fbc03664d41ced37df6 (diff)
downloadqpid-python-f0f982abaa645bcf1036ee963498cd6fd5a2fa79.tar.gz
QPID-5279: checks for exclusivity in linking to queue
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1537496 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'qpid/cpp/src')
-rw-r--r--qpid/cpp/src/qpid/broker/amqp/Session.cpp12
1 files changed, 9 insertions, 3 deletions
diff --git a/qpid/cpp/src/qpid/broker/amqp/Session.cpp b/qpid/cpp/src/qpid/broker/amqp/Session.cpp
index baee3c098c..25bba04fbd 100644
--- a/qpid/cpp/src/qpid/broker/amqp/Session.cpp
+++ b/qpid/cpp/src/qpid/broker/amqp/Session.cpp
@@ -284,10 +284,13 @@ Session::ResolvedNode Session::resolve(const std::string name, pn_terminus_t* te
}
}
- if (node.properties.isExclusive() && node.queue && node.queue->setExclusiveOwner(this)) {
- exclusiveQueues.insert(node.queue);
+ if (node.properties.isExclusive() && node.queue) {
+ if (node.queue->setExclusiveOwner(this)) {
+ exclusiveQueues.insert(node.queue);
+ } else {
+ throw Exception(qpid::amqp::error_conditions::PRECONDITION_FAILED, std::string("Cannot grant exclusive access to ") + node.queue->getName());
+ }
}
-
return node;
}
@@ -417,6 +420,9 @@ void Session::setupOutgoing(pn_link_t* link, pn_terminus_t* source, const std::s
if (node.queue) {
authorise.outgoing(node.queue);
SubscriptionType type = pn_terminus_get_distribution_mode(source) == PN_DIST_MODE_COPY ? BROWSER : CONSUMER;
+ if (type == CONSUMER && node.queue->hasExclusiveOwner() && !node.queue->isExclusiveOwner(this)) {
+ throw Exception(qpid::amqp::error_conditions::PRECONDITION_FAILED, std::string("Cannot consume from exclusive queue ") + node.queue->getName());
+ }
boost::shared_ptr<Outgoing> q(new OutgoingFromQueue(connection.getBroker(), name, target, node.queue, link, *this, out, type, false, node.properties.trackControllingLink()));
q->init();
filter.apply(q);