diff options
| author | Rajith Muditha Attapattu <rajith@apache.org> | 2013-03-06 21:04:51 +0000 |
|---|---|---|
| committer | Rajith Muditha Attapattu <rajith@apache.org> | 2013-03-06 21:04:51 +0000 |
| commit | 89aa2dcbe70954e8c83993cee306a910beae8844 (patch) | |
| tree | 01ca10c7057cce3803c54ca4e1da25b3fb8ac6e7 /qpid/java/client | |
| parent | a0a4fd7f3dafadcfd635c725de914367529fd7b3 (diff) | |
| download | qpid-python-89aa2dcbe70954e8c83993cee306a910beae8844.tar.gz | |
QPID-3396 Changed the test cases to relect that username and password
is optional.
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1453559 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'qpid/java/client')
2 files changed, 4 insertions, 5 deletions
diff --git a/qpid/java/client/src/main/java/org/apache/qpid/client/transport/ClientConnectionDelegate.java b/qpid/java/client/src/main/java/org/apache/qpid/client/transport/ClientConnectionDelegate.java index 2775354acf..e9b946d5b7 100644 --- a/qpid/java/client/src/main/java/org/apache/qpid/client/transport/ClientConnectionDelegate.java +++ b/qpid/java/client/src/main/java/org/apache/qpid/client/transport/ClientConnectionDelegate.java @@ -98,7 +98,8 @@ public class ClientConnectionDelegate extends ClientDelegate " Client restricted itself to : " + (restrictionList != null ? restrictionList : "no restriction")); } - if (CallbackHandlerRegistry.getInstance().isUserPassRequired(selectedMech)) + if ((_connectionURL.getUsername() == null || _connectionURL.getPassword() == null) + && CallbackHandlerRegistry.getInstance().isUserPassRequired(selectedMech)) { throw new ConnectionException("Username and Password is required for the selected mechanism : " + selectedMech + " Broker allows : " + brokerMechanisms + diff --git a/qpid/java/client/src/test/java/org/apache/qpid/test/unit/client/connectionurl/ConnectionURLTest.java b/qpid/java/client/src/test/java/org/apache/qpid/test/unit/client/connectionurl/ConnectionURLTest.java index 8c193622e3..7c461fa13f 100644 --- a/qpid/java/client/src/test/java/org/apache/qpid/test/unit/client/connectionurl/ConnectionURLTest.java +++ b/qpid/java/client/src/test/java/org/apache/qpid/test/unit/client/connectionurl/ConnectionURLTest.java @@ -384,11 +384,10 @@ public class ConnectionURLTest extends TestCase try { new AMQConnectionURL(url); - fail("URL Should not parse"); } catch (URLSyntaxException urise) { - assertTrue(urise.getMessage().startsWith("User information not found on url")); + fail("User information is optional in url"); } } @@ -400,11 +399,10 @@ public class ConnectionURLTest extends TestCase try { new AMQConnectionURL(url); - fail("URL Should not parse"); } catch (URLSyntaxException urise) { - assertTrue(urise.getMessage().startsWith("User information not found on url")); + fail("User information is optional in url"); } } |