diff options
| author | Robert Godfrey <rgodfrey@apache.org> | 2012-02-20 16:36:24 +0000 |
|---|---|---|
| committer | Robert Godfrey <rgodfrey@apache.org> | 2012-02-20 16:36:24 +0000 |
| commit | c41afcbdb24a3578b5c4796d57df51a66a54af34 (patch) | |
| tree | 006e476297b38ea96816fe3f9a426fc4ac919990 /qpid/java/client | |
| parent | 74ab215737ab1943f1366b0400d90429d309cc03 (diff) | |
| download | qpid-python-c41afcbdb24a3578b5c4796d57df51a66a54af34.tar.gz | |
QPID-3095 : AMQBrokerDetails equals() and hashCode() methods do not adhere to contract
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1291353 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'qpid/java/client')
| -rw-r--r-- | qpid/java/client/src/main/java/org/apache/qpid/client/AMQBrokerDetails.java | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/qpid/java/client/src/main/java/org/apache/qpid/client/AMQBrokerDetails.java b/qpid/java/client/src/main/java/org/apache/qpid/client/AMQBrokerDetails.java index 771e80c3bc..987404cb80 100644 --- a/qpid/java/client/src/main/java/org/apache/qpid/client/AMQBrokerDetails.java +++ b/qpid/java/client/src/main/java/org/apache/qpid/client/AMQBrokerDetails.java @@ -319,18 +319,18 @@ public class AMQBrokerDetails implements BrokerDetails BrokerDetails bd = (BrokerDetails) o; - return _host.equalsIgnoreCase(bd.getHost()) && + return _host.toLowerCase().equals(bd.getHost() == null ? null : bd.getHost().toLowerCase()) && (_port == bd.getPort()) && - _transport.equalsIgnoreCase(bd.getTransport()); + _transport.toLowerCase().equals(bd.getTransport() == null ? null : bd.getTransport().toLowerCase()); //TODO do we need to compare all the options as well? } @Override public int hashCode() { - int result = _host != null ? _host.hashCode() : 0; + int result = _host != null ? _host.toLowerCase().hashCode() : 0; result = 31 * result + _port; - result = 31 * result + (_transport != null ? _transport.hashCode() : 0); + result = 31 * result + (_transport != null ? _transport.toLowerCase().hashCode() : 0); return result; } |
